View Issue Details

IDProjectCategoryView StatusLast Update
0005943Composrhealth_checkpublic2024-11-12 19:14
ReporterAdam EdingtonAssigned ToPatrick Schmalstig 
SeverityTrivial-bug 
Status resolvedResolutionfixed 
Product Version11.beta4 
Fixed in Version 
Summary0005943: Deleting the Health Check addon leaves a task in Admin CP
DescriptionThe custom task "Run/Schedule Health Checks" is not deleted when the addon is.
TagsRoadmap: v11
Time estimation (hours)
Sponsorship open

Activities

Patrick Schmalstig

2024-11-12 17:46

administrator   ~0009566

This is registered as a custom task rather than hook-based per addon. That should not be the case. I'm going to modify it to be addon hook based.

admin

2024-11-12 19:12

administrator   ~0009567

Automated response: Deleting the Health Check addon leaves a task in Admin CP

The health check task was being installed as a custom task rather than being a hook on the main_staff_checklist block. Therefore, the task would remain even after uninstalling health check.

This hotfix fixes that. Note that if the custom task exists, it will still need to be manually deleted from the checklist. But this adds a health check specific task linked to the addon.

admin

2024-11-12 19:12

administrator   ~0009568

Fixed in Git commit 71f3cb179b (https://gitlab.com/composr-foundation/composr/commit/71f3cb179b - link will become active once code pushed to GitLab)

admin

2024-11-12 19:12

administrator  

hotfix-5943, 2024-11-12 7pm.tar (327,680 bytes)

admin

2024-11-12 19:12

administrator   ~0009569

A hotfix (a TAR of files to upload) has been uploaded to this issue. Only apply this hotfix if you absolutely need it and cannot wait until the next release of Composr (releases are more reliable and strictly tested). As of Composr version 11, the recommended way to apply a hotfix is by following the same steps as an upgrade (https://baseurl/upgrader.php, use the hotfix on the step “Transfer across new/updated files”). The upgrader will automatically skip files belonging to addons you do not have installed or that are newer on disk than in the hotfix. Otherwise, you can manually extract and replace these files (do not replace if your on-disk file is newer than the one in the hotfix). Always take backups of your site or at least files you are replacing before applying a hotfix. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Patrick Schmalstig

2024-11-12 19:14

administrator   ~0009570

Apparently the actual hook did not get pushed into the hotfix. You may need to check for the commit after the one linked above.

Issue History

Date Modified Username Field Change
2024-09-15 02:10 Adam Edington New Issue
2024-11-12 17:45 Patrick Schmalstig Tag Attached: Roadmap: v11
2024-11-12 17:46 Patrick Schmalstig Assigned To => Patrick Schmalstig
2024-11-12 17:46 Patrick Schmalstig Status non-assigned => assigned
2024-11-12 17:46 Patrick Schmalstig Note Added: 0009566
2024-11-12 19:14 Patrick Schmalstig Note Added: 0009570