Fatal error after update to 10.0.14

From v10.0.10

Fatal error: Call to undefined function cns_get_custom_fields_member() in /home3/joe2209/bosslife.org/sources_custom/symbols.php on line 2250

Here's the function relevant to line 2250 from symbols.php of version 10.0.14: (working file)

---

Here's the function relevant to line 2250 from symbols.php of version 10.0.10 (non-working file):

On a side note, I'm not sure why it's different or even why I have a custom version; most likely to fix a bug or two that I reported recently.

Oh boy, it gets worse. Not sure I like upgrading anymore.

So I think the reason I had a custom symbols.php is because I actually added a symbol way back when, to check if a specific named cookie exists. Maybe a change made in v10.0.14's symbols.php was causing this issue. Anyways, I just copied over my custom symbol to the new symbols.php and this has fixed this error but it seems I have another:

3: TypeError: $(…).inputDate is not a function
https://bosslife.org/themes/start/templates_cached/EN/global_ssl.js?1523290836 line 742 > eval

This occurs when trying to edit my profile. If I dismiss the error and try to change a CPF value, the change is not saved.

This issue is also affecting fractional editable areas of my site (for editing these CPFs). I assume the reason why is related to this issue.

UPDATE:

I think it's something to do with FORM_SCREEN_INPUT_DATE.tpl

I looked on Github and found that these lines were deleted:

(line 21) $('#{NAME;/}').inputDate({});
(line 22) $('#{NAME;/}_time').inputTime({});

And these were added in v10.0.14:

(line 21) if (!Modernizr.inputtypes.date) $('#{NAME;/}').inputDate({});
(line 22) if (!Modernizr.inputtypes.time) $('#{NAME;/}_time').inputTime({});

Upon inspection of my FORM_SCREEN_INPUT_DATE.tpl file, I noticed these changes were not made during my upgrade. I made the changes manually and now I'm getting this error when attempting to edit my profile:

4: SyntaxError: expected expression, got keyword 'if'
https://bosslife.org/themes/start/templates_cached/EN/global_ssl.js?1523311610

---

UPDATE 2:
I reverted FORM_SCREEN_INPUT_DATE.tpl to a backup I had of v10.0.10, which contained this:

{+START,SET,comment}
   Uncomment if you want to force jQuery-UI inputs even when there is native browser input support
   <span>// <![CDATA[
      add_event_listener_abstract(window,'load',function() {
         $('#{NAME;/}').inputDate({});
         $('#{NAME;/}_time').inputTime({});
      });
   //]]></span>
{+END}

This stopped the error from popping up, but I'm still having issues saving CPFs.

---

UPDATE 3:
Ok, this is weird… looking at the deletions and additions on GitHub for v10.0.14, I'm noticing that none of these changes were made to my installation. As far as I can tell, none of the files appear to have been modified by the upgrader. But this must not be true as the upgrade is what caused the issue, so something somewhere changed, I just don't know what. I'm totally confused as to what's going on. I've racked my brain on this one.

Hi Joe,

I'll tackle this in parts, as there's a lot here. So first let us talk about overrides…

Overriding is always a risk, and things get technical. Where possible we make it so that things can be done with either minimal overrides or hooks.

You likely don't know this yet: when you override a Composr include that just consists of functions, you can just declare the new function in the override, leaving out anything else. Composr automatically merges with the original.

Also it is possible to implement symbols as hooks. sources/hooks/systems/symbols.

Why did things break? We had to change the cns_get_custom_fields_member stuff a bit, I can't quite remember why though to be honest– there was something subtly wrong about how it was structured.

A quick note about upgrading-

It may be wise to test an upgrade on a site where you have overrides, or where it's been a while since the last upgrade, on a clone of your live site. Then you can make sure things are going to go smoothly when you upgrade the real site.

There's a tutorial somewhere about clone sites.

Upon inspection of my FORM_SCREEN_INPUT_DATE.tpl file, I noticed these changes were not made during my upgrade. I made the changes manually and now I'm getting this error when attempting to edit my profile:

These are coming in the next release. There's been some back-and-forth bugginess around date input I'm afraid.

4: SyntaxError: expected expression, got keyword 'if'

I think this may have been caused by an intra-release bug in cms_calendar.php, if you were using that module at the time and uploaded a change to it. It's weird your error message says global.js though, so maybe not - maybe some problem caused when uploading global.js only partially or it corrupting during upload. Anyway, you say it's gone, so I'll leave it there unless it comes back.

This stopped the error from popping up, but I'm still having issues saving CPFs.

This may actually be an unrelated bug affecting some users in the latest release. Try grabbing these files from github:

• sources/forum/cns.php
• sources/cns_topicview.php
• sources/cns_members.php

Sorry for the inconvenience there. There was a lot of time between the last and most recent patch release, so while a lot was fixed, there were the couple of regressions we've discussed here (date input and CPF saving issues).

Ok, we're operational again. Thanks Chris!

These are coming in the next release. There's been some back-and-forth bugginess around date input I'm afraid.

So I assume the contents of FORM_SCREEN_INPUT_DATE.tpl should remain as:

{+START,SET,comment}
   Uncomment if you want to force jQuery-UI inputs even when there is native browser input support
   <span>// <![CDATA[
      add_event_listener_abstract(window,'load',function() {
         $('#{NAME;/}').inputDate({});
         $('#{NAME;/}_time').inputTime({});
      });
   //]]></span>
{+END}

…until the next release, correct?

You could try the latest themes/default/templates/FORM_SCREEN_INPUT_DATE.tpl and themes/default/templates/FORM_SCREEN_INPUT_TIME.tpl again, they should work.