View Issue Details

IDProjectCategoryView StatusLast Update
0002417Composrcore_configurationpublic2017-12-03 00:20
ReporterAdam EdingtonAssigned ToChris Graham 
SeverityFeature-request 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0002417: Bypass submission blocking for admin
DescriptionWould be helpful if this was off for admins and/or staff. I have 2 bands called Arise I wanted to add to a catalogue, the second one got blocked. As an admin, I shouldn't have to wait 4 minutes to do anything.
TagsGood for training
Time estimation (hours)2
Sponsorship open

Activities

Adam Edington

2016-04-18 00:12

administrator  

admin_bypass.png (9,682 bytes)
admin_bypass.png (9,682 bytes)

Patrick Schmalstig

2016-04-19 13:50

administrator   ~0003606

I think personally it should stay in place but be reduced to 60 seconds. This is so there's less wait for staff, but it still protects against "double submitting" accidents.

Adam Edington

2016-04-19 20:46

administrator   ~0003608

Even 60 seconds seems like overkill, maybe just a warning with a proceed button would be better. For admins and everyone else. I don't understand why a time limit needs to be part of this.

Chris Graham

2016-04-19 20:58

administrator   ~0003609

^ I agree

Patrick Schmalstig

2016-04-19 22:38

administrator   ~0003610

I think it's a good feature to have for spam protection (the time limit)... but your staff shouldn't be spamming anyway. If the time limit does get removed, I do suggest at least a warning for similar submitted content.

Chris Graham

2016-04-20 23:32

administrator   ~0003640

Last edited: 2016-04-20 23:33

View 2 revisions

Ok on reflection, the time limit is for a technical reason. It uses the admin logs to check for duplication, but of course naturally some titles may be repeated, especially over different categories - it can't distinguish categories, so it uses time as a reasonable alternative qualifier.

I think the time limit could be configurable, there could be a privilege for bypassing a forced wait, and if that privilege is there it could be a click-through screen.

OR instead of a time limit/wait...

We could throw out the time limit and use the CSRF tokens instead. If something with a shared title and CSRF token was already submitted, we could use that as the qualifier.

(We don't delete CSRF tokens upon posting btw, as that's super annoying, so CSRF tokens don't *automatically* prevent double submissions. It annoys me in MantisBT [here], you can't use the back button properly. We do expire them though.).

Adam Edington

2016-04-21 23:11

administrator   ~0003646

Last edited: 2016-04-21 23:13

View 3 revisions

"I think the time limit could be configurable, there could be a privilege for bypassing a forced wait, and if that privilege is there it could be a click-through screen." This gets my vote. Does the job intended but maybe the other method is a better fit overall. You can decide :)

Chris Graham

2017-12-03 00:20

administrator   ~0005287

We discussed this in our live chat. The reporting happens on the calendar, where it's legitimate to make multiple entries with the same title.
I think just having a proceed button is fine. It's not a security feature, as if someone wanted to flood a site they could write a bot to do it anyway - so the separate flood control settings are where you deal with this scenario.

So, now a proceed button is implemented, works well.

Issue History

Date Modified Username Field Change
2016-04-18 00:12 Adam Edington New Issue
2016-04-18 00:12 Adam Edington File Added: admin_bypass.png
2016-04-19 01:59 Chris Graham Category core => core_configuration
2016-04-19 01:59 Chris Graham View Status private => public
2016-04-19 01:59 Chris Graham Time estimation (hours) => 0.3
2016-04-19 13:50 Patrick Schmalstig Note Added: 0003606
2016-04-19 20:46 Adam Edington Note Added: 0003608
2016-04-19 20:58 Chris Graham Note Added: 0003609
2016-04-19 22:38 Patrick Schmalstig Note Added: 0003610
2016-04-20 23:32 Chris Graham Note Added: 0003640
2016-04-20 23:33 Chris Graham Note Edited: 0003640 View Revisions
2016-04-21 23:11 Adam Edington Note Added: 0003646
2016-04-21 23:13 Adam Edington Note Edited: 0003646 View Revisions
2016-04-21 23:13 Adam Edington Note Edited: 0003646 View Revisions
2016-10-19 16:04 Chris Graham Time estimation (hours) 0.3 => 2
2017-11-26 16:08 Chris Graham Tag Attached: Can implement during live chat
2017-12-03 00:20 Chris Graham Note Added: 0005287
2017-12-03 00:20 Chris Graham Status non-assigned => resolved
2017-12-03 00:20 Chris Graham Resolution open => fixed
2017-12-03 00:20 Chris Graham Assigned To => Chris Graham
2019-06-27 19:42 Chris Graham Tag Renamed Can implement during live chat => Good for training