View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003447 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2017-12-05 04:53 | 2017-12-12 09:43 |
| Reporter | Chris Graham | Assigned To | Salman | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0003447: js_ssl_issues test failing | ||||
| Description | Fail: js_ssl_issues_test_set -> testSSLIssues -> backup.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> button_commandr.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> button_realtime_rain.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> chat.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> CMS_UI.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> CMS_VIEWS.js/button_lightbox_close not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> CMS_VIEWS.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_feedback_features.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_notifications.js/favicon not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_permission_management.js/blank not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_permission_management.js/led_on not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_permission_management.js/led_off not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_rich_media.js/mediaset_previous not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_rich_media.js/mediaset_next not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_rich_media.js/big_tabs_controller_button not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_rich_media.js/big_tabs_controller_button_active not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_rich_media.js/big_tabs_controller_button_top_active not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_rich_media.js/big_tabs_controller_button_top not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_themeing.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> core_zone_editor.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> DOM.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> galleries.js/blank not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> jquery_autocomplete.js/blank not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> news.js/blank not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Fail: js_ssl_issues_test_set -> testSSLIssues -> tree_list.js/loading not prepared for SSL at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/js_ssl_issues.php line 32] Maybe you just need to fix the test to match your code pattern, I'm not sure. The key thing is $IMG usually gives an absolute path, but JS code will cache in the same bucket for both HTTPS and HTTP, hence needs to be protocol agnostic. You may want to give some general thought in case anything else is broken in this regard. | ||||
| Tags | No tags attached. | ||||
| Sponsorship open | |||||
|
|
I fixed the test to match what we're using now: $util.srl() makes URLs scheme-relative by removing the protocol altogether. (https://www.paulirish.com/2010/the-protocol-relative-url/) https://github.com/ocproducts/composr/commit/5b6066f1633525e398e1d4970e5f46506e45f3b6 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-12-05 04:53 | Chris Graham | New Issue | |
| 2017-12-05 04:53 | Chris Graham | Status | non-assigned => assigned |
| 2017-12-05 04:53 | Chris Graham | Assigned To | => Salman |
| 2017-12-12 09:42 | Salman | Note Added: 0005301 | |
| 2017-12-12 09:43 | Salman | Status | assigned => resolved |
| 2017-12-12 09:43 | Salman | Resolution | open => fixed |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
