View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003448 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2017-12-05 05:57 | 2017-12-12 19:20 |
| Reporter | Chris Graham | Assigned To | Salman | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0003448: Fix template_previews test | ||||
| Description | The template_previews test is failing on at least 2 issues... 1) Menu templates have been altered to include images and link text under the same <a> tag. This will always show an underline in the gap. This will need resolving in some way, e.g. using CSS background images with padding, or just doing what we did before (2 <a> tags). Once this is fixed re-enable the XHTML_A_SPACES check in sources/webstandards2.php 2) <script type="text/html" in BLOCK_MAIN_IMAGE_FADER_NEWS.tpl is breaking the validator code badly. The validator code will probably need some changes to make it not apply the same validation rules to text/html. That said, I believe validators will see <script> as CDATA, and that means you're supposed to use CDATA escaping of closing tags in there, which isn't happening here. Make sure that real HTML5 validators don't fail on your current HTML. There may be other issues, but I'm stuck at these right now. | ||||
| Additional Information | It's important the web standard checks continue to work, as this is how we make sure we maintain code validation across the ~ 1000 templates - if our code doesn't validate, that will be seen very negatively by a subgroup of people (and manual validation of 100s of screens each release isn't viable). So please run this test after making heavy changes to make sure things aren't breaking. | ||||
| Tags | No tags attached. | ||||
| Sponsorship open | |||||
|
|
Actually it is just those 2 issues. I added Salman TODOs to get the test to pass, but you'll need to deal with them. (In my next commit) |
|
|
I had to move to single <a>'s to make the hamburger menu merging possible. I'll see what I can do. |
|
|
Fixed #1 by using margins on the image icons itself. Fixed 0000002 by changing the web standards code to allow scripts with type 'text/html'. CDATA is for escaping entity characters <,>,& etc. when used in JS, it doesn't apply for the valid XML/HTML inside that script element. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-12-05 05:57 | Chris Graham | New Issue | |
| 2017-12-05 05:57 | Chris Graham | Status | non-assigned => assigned |
| 2017-12-05 05:57 | Chris Graham | Assigned To | => Salman |
| 2017-12-05 05:58 | Chris Graham | Additional Information Updated | View Revisions |
| 2017-12-05 06:05 | Chris Graham | Note Added: 0005294 | |
| 2017-12-12 09:45 | Salman | Note Added: 0005302 | |
| 2017-12-12 19:20 | Salman | Note Added: 0005305 | |
| 2017-12-12 19:20 | Salman | Status | assigned => resolved |
| 2017-12-12 19:20 | Salman | Resolution | open => fixed |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
