View Issue Details

IDProjectCategoryView StatusLast Update
0003494Composrcore_themeingpublic2018-01-28 22:42
ReporterAdam EdingtonAssigned ToChris Graham 
SeverityTrivial-bug 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0003494: Welcome and Site Zone differences
DescriptionI have noticed that if I create some content (specifically an image based grid catalogue) in the Site Zone, then switch to Single Public Zone, the content gets skewed like the widths are not the same in both Zones. In the Site Zone, both side panels move with the page but it's only the right panel that moves in the Welcome Zone.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

Chris Graham

2018-01-20 14:14

administrator   ~0005379

I don't understand this.

"the content gets skewed like the widths are not the same in both Zones"

Skewed typically means gets dragged in an angled direction.
Dictionary: "suddenly change direction or position."
I don't think that's what you mean.

"like the widths are not the same in both Zones"

I'm not sure why they would be the same, if panels are different.
I'm also not sure why it would be an issue, as it's presumably not going to have to show in both situations at once, so normal layout and templating would be used to set the layout desired.

"In the Site Zone, both side panels move with the page but it's only the right panel that moves in the Welcome Zone."

I think by "move with", you're referring to what happens when you do vertical scrolling. I'm not sure what that has to do with widths or skewing though, and I'm not aware of any difference. Likely your site just has a tall panel that can't all display on the screen at once, so Composr won't try and sticky it.

Adam Edington

2018-01-20 18:45

administrator   ~0005385

Yeah skewed wasn't the right word. I simply meant that default catalogue image grid is displayed different in both zones (fits better in Site than Welcome) despite the side panels being the same width (I would assume). If someone created something in Site then changed to to Single Public Zone it may not display the same and I assumed the layout would be the same regardless of zone.

Chris Graham

2018-01-20 19:17

administrator   ~0005386

If you can attach a pair of screenshots that may help.

Adam Edington

2018-01-21 05:56

administrator  

site_zone.png (350,091 bytes)

Adam Edington

2018-01-21 05:58

administrator  

welcome_zone2.png (221,759 bytes)
welcome_zone2.png (221,759 bytes)

Adam Edington

2018-01-21 05:59

administrator   ~0005391

Uploaded, ignore welcome_zone.png, that's actually the site zone view again :P

Chris Graham

2018-01-21 18:48

administrator   ~0005394

If the Single Public Zone option is off, more space is given around the right panel due to this CSS rule...

    /*{+START,IF,{$CONFIG_OPTION,collapse_user_zones}}*/
        .zone_running_ #panel_right:first-child ~ .global_middle { /* If no left panel on welcome zone, lets give some extra space */
            margin-{!en_right}: 16em;
        }
    /*{+END}*/


This is simply because a splash page probably is going to be more sparse and wanting to make use of more white-space.

So there's no bug here, simply the default styles dictate more space on the welcome zone.

Adam Edington

2018-01-25 23:49

administrator   ~0005405

Okay, I was just reporting the scenario where someone switches from the default to single public zone after they've set things up to their liking and finding that it doesn't display the same (which would be expected imho). It's not a major thing, I wouldn't have assumed it was a CSS rule and I still don't fully understand what Collapse User Zones even means/does. I assume it would remove the panels like in other software (but they tend to just hide them via a toggle in my experience of other software). I just thought the welcome zone should follow the styling rules of other zones, I am happy to accept it doesn't just not entirely sure why it wouldn't :)

Chris Graham

2018-01-28 16:58

administrator   ~0005408

Actually, you're right. The rule was targeting when collapse zones was on, when it should have targeted when it is off. I've just removed it.
It only applies when there is a right panel and no left panel.

Collapse zones ("single public zone" option) is when the welcome and site zone are automatically merged by Composr - i.e. there's no visibly separate site zone, and all the site zone pages run from the welcome zone instead. It's not actually really anything to do with panels.

Adam Edington

2018-01-28 22:27

administrator   ~0005411

Last edited: 2018-01-28 22:39

View 2 revisions

I would never have considered Single Public Zone and Collapse User Zones to be connected things (based on the different terminology, maybe Merge Default Zones would be more fitting). I understood collapse as destroying the supporting columns (sidebars) in zones for a full width view, lol :)

Chris Graham

2018-01-28 22:42

administrator   ~0005412

Yeah, that is confusing. The config option was implemented before the final 'Single Public Zone' label for it was decided. I'll make it consistent in v11.

Issue History

Date Modified Username Field Change
2018-01-20 12:17 Adam Edington New Issue
2018-01-20 14:14 Chris Graham Note Added: 0005379
2018-01-20 14:22 Chris Graham Status non-assigned => closed
2018-01-20 14:22 Chris Graham Assigned To => Chris Graham
2018-01-20 14:22 Chris Graham Resolution open => suspended
2018-01-20 18:45 Adam Edington Note Added: 0005385
2018-01-20 19:17 Chris Graham Note Added: 0005386
2018-01-21 05:56 Adam Edington File Added: welcome_zone.png
2018-01-21 05:56 Adam Edington File Added: site_zone.png
2018-01-21 05:58 Adam Edington File Added: welcome_zone2.png
2018-01-21 05:59 Adam Edington Note Added: 0005391
2018-01-21 18:45 Chris Graham File Deleted: welcome_zone.png
2018-01-21 18:48 Chris Graham Note Added: 0005394
2018-01-25 23:49 Adam Edington Note Added: 0005405
2018-01-28 16:58 Chris Graham Note Added: 0005408
2018-01-28 16:58 Chris Graham Status closed => resolved
2018-01-28 16:58 Chris Graham Resolution suspended => fixed
2018-01-28 22:27 Adam Edington Note Added: 0005411
2018-01-28 22:39 Adam Edington Note Edited: 0005411 View Revisions
2018-01-28 22:42 Chris Graham Note Added: 0005412