View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003523 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2018-02-02 01:53 | 2018-02-11 14:13 |
| Reporter | Chris Graham | Assigned To | Salman | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0003523: Should not use $PAGE_LINK symbol in JS | ||||
| Description | facebook_support.js is using $PAGE_LINK. However, $PAGE_LINK will propagate keep_* variables, including URL-based session IDs. Right now those will be written into the shared JS cache. These URLs need to be coming through to the JS via data-attributes. | ||||
| Tags | No tags attached. | ||||
| Sponsorship open | |||||
|
|
Also I found: link: '{$PAGE_LINK;,:privacy}', |
|
|
Fixed both. There are two more usages which have the third parameter (skip_keep) set to '1', are those okay? |
|
|
I can only see: fauxmodal_alert('{!chat:_FAILED_TO_OPEN_POPUP;,{$PAGE_LINK*,_SEARCH:popup_blockers:failure=1,0,1}}',null,'{!chat:FAILED_TO_OPEN_POPUP;^}',true); That one is fine. It shouldn't need keep propagation for an exceptional event in the chat system. a) Chatters are unlikely to be missing session cookies b) It's so exceptional I wouldn't want it to have to go through a data attribute. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-02-02 01:53 | Chris Graham | New Issue | |
| 2018-02-02 01:53 | Chris Graham | Status | non-assigned => assigned |
| 2018-02-02 01:53 | Chris Graham | Assigned To | => Salman |
| 2018-02-02 01:53 | Chris Graham | Description Updated | View Revisions |
| 2018-02-06 22:09 | Chris Graham | Note Added: 0005445 | |
| 2018-02-11 09:48 | Salman | Note Added: 0005495 | |
| 2018-02-11 14:13 | Guest | Note Added: 0005496 | |
| 2018-02-11 14:13 | Chris Graham | Status | assigned => resolved |
| 2018-02-11 14:13 | Chris Graham | Resolution | open => fixed |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
