View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003570 | Composr | core_comcode_pages | public | 2018-03-28 21:57 | 2018-03-31 03:04 |
| Reporter | Adam Edington | Assigned To | Chris Graham | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Product Version | |||||
| Fixed in Version | |||||
| Summary | 0003570: Join our banner scheme link | ||||
| Description | Clicking this link (from the advertise page) to the CMS zone banners module loads the login page as expected when viewing as a guest but the page doesn't have a header (just the content and the footer). This is likely due to the CMS zone having the admin theme. | ||||
| Tags | No tags attached. | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
No menu will be shown if there's no access. |
|
|
Perhaps this link should not be shown on the Advertising Opportunity page to Guests if the link is going to the CMS? It just looks like the site hasn't loaded properly. |
|
|
There is actually no advertise page. It's created from a template manually by the admin, and it's expected that the admin will edit the template as they feel is appropriate. We cannot show an empty menu, and I think it is appropriate to have a link in the template, and we don't want to do an admin theme redesign, so I don't think there's any change here. |
|
|
'Use the welcome zone theme on login screens' fixes this issue (and I expect any others like it). Maybe this should be enabled by default? |
|
|
People are liable to do all kinds of funky things to the main website theme which may cause it to break when running in contexts the themer didn't expect. For example, they may code in CSS that assumes the welcome zone's panels are there. We could probably put the logo at the top of the theme if there's no menu there. I'll create an issue for that, but it certainly wouldn't get done as a bugfix in v10 because it would be a major styling change. |
|
|
Yeah, that all makes sense but I imagine enabling that option by default would be better (for most) than a new site admin creating a page from an included template which has a link that displays oddly to guests (perhaps also members with no access) in a zone they likely have no access to and which actually requires registration and not just login for Guests. To me it would make sense if it linked to the Join page if a user is not already logged in. Even a welcome zone with no panels would display the header and background colour from the default theme (I think). But yes, the logo instead of a menu would be good too and might more a lot more sense from a developer perspective. I am, as ever, talking from an end user perspective. |
|
|
I really do appreciate your thoughts. When it comes to v10, I am going to be very conservative about what changes. |
|
|
Ok I took a look, and actually you did find a bug. It is supposed to show a very cut down alternative menu. But if the single public zone option is off, it fails because it fails on permissions to the site zone for guests - the result is an empty menu. I fixed that, and did a bit more tuning. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-03-28 21:57 | Adam Edington | New Issue | |
| 2018-03-28 22:39 | Chris Graham | Note Added: 0005634 | |
| 2018-03-28 22:39 | Chris Graham | Status | non-assigned => closed |
| 2018-03-28 22:39 | Chris Graham | Assigned To | => Chris Graham |
| 2018-03-28 22:39 | Chris Graham | Resolution | open => won't fix |
| 2018-03-28 23:04 | Adam Edington | Note Added: 0005635 | |
| 2018-03-28 23:08 | Chris Graham | Note Added: 0005636 | |
| 2018-03-28 23:17 | Adam Edington | Note Added: 0005637 | |
| 2018-03-28 23:22 | Chris Graham | Note Added: 0005638 | |
| 2018-03-28 23:37 | Adam Edington | Note Added: 0005639 | |
| 2018-03-28 23:39 | Chris Graham | Note Added: 0005640 | |
| 2018-03-31 03:04 | Chris Graham | Note Added: 0005645 | |
| 2018-03-31 03:04 | Chris Graham | Status | closed => resolved |
| 2018-03-31 03:04 | Chris Graham | Resolution | won't fix => fixed |
