View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003601 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2018-04-30 17:40 | 2018-07-30 00:07 |
| Reporter | Chris Graham | Assigned To | Salman | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0003601: Many automated tests failing | ||||
| Description | The main issues are below. Finish the core work, then when done make sure all the tests pass. Obviously the tests themselves can be adjusted if needed. http://localhost/composr/_tests/index.php?id=unit_tests/lang_no_unused&close_if_passed=1 Fail: lang_no_unused_test_set -> testNothingUnused -> MARK_TASK_DONE: cannot find usage of language string (Click to mark task done) at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/lang_no_unused.php line 227] http://localhost/composr/_tests/index.php?id=unit_tests/microformats&close_if_passed=1 Lots like: Exception: microformats_test_set -> testHCalendar -> Unexpected PHP error [file_get_contents(/Library/WebServer/Documents/composr/themes/_unnamed_/images/icons/sprite.svg) [<a href='http://php.net/manual/en/function.file-get-contents.php'>function.file-get-contents.php</a>]: failed to open stream: No such file or directory] severity [E_WARNING] in [/Library/WebServer/Documents/composr/sources/symbols.php line 6511] This is probably an issue assuming that a theme image exists in any theme. Other tests are failing similarly. http://localhost/composr/_tests/index.php?id=unit_tests/optimisations_fragile&close_if_passed=1 Lots like: Fail: optimisations_fragile_test_set -> testSymbols2Optimisation -> Loaded symbols2.php in module galleries at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/optimisations_fragile.php line 53] You need to make sure any commonly used symbols are in symbols.php and non-commonly used ones are in symbols2.php. http://localhost/composr/_tests/index.php?id=unit_tests/basic_code_formatting&close_if_passed=1 Many errors, trailing white-space and incorrect number of blank lines at the end of files. I've fixed many issues like this before, but you need to maintain this yourself now. http://localhost/composr/_tests/index.php?id=unit_tests/comment_encapsulation&close_if_passed=1 Many errors. I think this mostly stems from using a directive for a parameter of a symbol. That's not allowed in Tempcode. You should use the SET directive instead. Then the test will pass as it's not misunderstanding the use of the Tempcode syntax. http://localhost/composr/_tests/index.php?id=unit_tests/web_resources&close_if_passed=1 The CSS/JS validation code needs updating if we are using things that are beyond the standards it recognises. E.g. SVG properties in CSS. Or, it may be finding legitimate issues in the code. | ||||
| Tags | No tags attached. | ||||
| Sponsorship open | 0 | ||||
|
|
Except those we've just discussed (which I'm working on), these are the outstanding issues (I re-ran all the tests)... http://localhost/composr/_tests/index.php?id=unit_tests/basic_code_formatting&close_if_passed=1 Has trailing whitespace in themes/default/javascript/CMS_VIEWS.js http://localhost/composr/_tests/index.php?id=unit_tests/config&close_if_passed=1 use_monochrome_icons must be accessed as a theme option (.php): adminzone/pages/modules/admin_svg_sprites.php http://localhost/composr/_tests/index.php?id=unit_tests/cqc_adminzone&close_if_passed=1 WARNING "adminzone/pages/modules/admin_svg_sprites.php" 214 75 PHP: Could not find function 'simplexml_load_string http://localhost/composr/_tests/index.php?id=unit_tests/sitemap&close_if_passed=1 No help defined for SVG sprites (adminzone:admin_svg_sprites) |
|
|
template_previews not only fails due to a few issues of yours. This takes a long time to run, and it creates files in _tests/screens_tested/. It's re-entrant, so if it times out you can refresh. |
|
|
All tests now passing as of writing. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-04-30 17:40 | Chris Graham | New Issue | |
| 2018-04-30 17:40 | Chris Graham | Status | non-assigned => assigned |
| 2018-04-30 17:40 | Chris Graham | Assigned To | => Salman |
| 2018-07-23 01:54 | Chris Graham | Note Added: 0005773 | |
| 2018-07-23 03:10 | Chris Graham | Note Added: 0005774 | |
| 2018-07-30 00:07 | Salman | Note Added: 0005778 | |
| 2018-07-30 00:07 | Salman | Status | assigned => resolved |
| 2018-07-30 00:07 | Salman | Resolution | open => fixed |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
