View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003616 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2018-05-28 01:15 | 2018-07-20 05:49 |
| Reporter | Chris Graham | Assigned To | Salman | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0003616: Broken uploads | ||||
| Description | As discussed on Skype | ||||
| Additional Information | Salman, 17:46 ok (y) just found some instances I missed when hyphenating id attributes Salman, 17:52 click_link(document.getElementById('uploadButton_file'+num_attachments)); is num_attachments a local variable or global aka window.num_attachments? oh looks like the latter Salman, 18:33 the submit_form_on_enter stuff was easy, just add data-submit-on-enter="1" to the desired elements haha click_link(document.getElementById('uploadButton_file'+num_attachments)); ^ is document.getElementById('uploadButton_file'+num_attachments) a button or a link? it won't work for a button as it looks like I replaced click_link() with $util.navigate(), which doesn't actually trigger a click event anymore rather only redirects to the value of the [href] attribute 19:46 I believe uploadButton_file is a button created dynamically in plupload.js var settings = getUploaderSettings(name, pageType, postingFieldName, filter); settings.progress_target = 'fs-upload-progress-' + name; settings.required = rep.classList.contains('required'); settings.browse_button = 'upload-button-' + name; settings.drop_element = 'txt_filename_' + name; settings.container = 'main-div-' + name; there it is, yes inconsistent Salman, 19:50 Ok I will check it after you commit. | ||||
| Tags | No tags attached. | ||||
| Sponsorship open | 0 | ||||
|
|
Should be fixed now. I've replaced the $util.navigate() call with a click_link() equivalent for non-links: $dom.trigger(element, 'click'). Couldn't test it unfortunately as I wasn't able to find out how to make the attachments UI show up, in a reasonable amount of time. Can you test it or give pointers? https://github.com/ocproducts/composr/commit/bfa00849a0ea31ceddeca96d39ab1ce5b3977aea |
|
|
Ah, it shows up with simplified attachments UI disabled, tested working now! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-05-28 01:15 | Chris Graham | New Issue | |
| 2018-05-28 01:15 | Chris Graham | Status | non-assigned => assigned |
| 2018-05-28 01:15 | Chris Graham | Assigned To | => Salman |
| 2018-07-19 06:01 | Salman | Note Added: 0005769 | |
| 2018-07-20 05:49 | Salman | Note Added: 0005771 | |
| 2018-07-20 05:49 | Salman | Status | assigned => resolved |
| 2018-07-20 05:49 | Salman | Resolution | open => fixed |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
