View Issue Details

IDProjectCategoryView StatusLast Update
0003939Composr alpha testing[All Projects] Generalpublic2020-03-24 16:03
ReporterChris GrahamAssigned ToSalman 
Severityfeature 
Status resolvedResolutionfixed 
Summary0003939: Default homepage_hero_slider slides are full of English
DescriptionIn site/pages/modules/galleries.php default slides are created, but they are full of English.

This is fairly problematic. It's not only that English is hard-coded, it's that right now there is no consideration of the content being potentially available in multiple languages on the same site at the point of installation - which is something we support for all other default content. And if we did put all this through the translation system as language strings, we'd be repeating a lot of HTML/CSS for each translation, which we do not want to have to do.

We can't channel it through included pages or page templates as that would be pretty bloaty, considering this is content that is significantly 'deeper' than pages. So I suggest changing the default content to use a Tempcode INCLUDE directive, to some new templates named something like GALLERIES_DEFAULT_HERO_SLIDER_1.tpl etc.
Once it is moved to templates, the English can be replaced with normal language string references.

I also wonder if this content is represented properly in the Setup Wizard - any default content like this needs to be removable by the setup wizard. See sources/hooks/modules/admin_setupwizard/banners.php as an example.
TagsNo tags attached.
Attach Tags
Sponsorship open

Relationships

related to 0003938 resolvedSalman main_hero_slider has hard-coded English 

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-10-31 21:21 Chris Graham New Issue
2019-10-31 21:21 Chris Graham Status non-assigned => assigned
2019-10-31 21:21 Chris Graham Assigned To => Salman
2019-10-31 21:21 Chris Graham Relationship added related to 0003938
2019-11-02 14:25 Chris Graham Project Composr testing platform => Composr alpha testing
2020-03-24 16:03 Chris Graham Status assigned => resolved
2020-03-24 16:03 Chris Graham Resolution open => fixed