View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004930 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2022-09-10 03:56 | 2022-09-15 01:30 |
| Reporter | Patrick Schmalstig | Assigned To | Chris Graham | ||
| Severity | Minor-bug | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0004930: sources/notifications2.php trying to access NTYPE on a Tempcode object | ||||
| Description | Line 180 in notifications2.php is "$ntype = $notification_type['NTYPE'];", which comes from a for loop on $notification_code['NOTIFICATION_TYPES']. However, $notification_code['NOTIFICATION_TYPES'] is set to $notification_types_tempcode on line 158 when it should be set to $notification_types. This fix does, however, break the template, so we also need to add "'NOTIFICATION_TYPES_TEMPCODE' => $notification_types_tempcode," after line 158. Then, modify NOTIFICATIONS_MANAGE.tpl to use {NOTIFICATION_TYPES_TEMPCODE} instead of {NOTIFICATION_TYPES} . | ||||
| Tags | No tags attached. | ||||
| Sponsorship open | |||||
|
|
(Would also need fixing in admin-notifications) |
|
|
I had very recently optimised the code to not generate an enormous Tempcode tree for the entire screen, given the memory issues we're having with the notification UI. The code had in hackerish way accessed the array structure used for the Tempcode tree (during setting saving). The correct fix was to clean up the code to not need to do that, having a proper data structure for what settings are active on the UI. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-09-10 03:56 | Patrick Schmalstig | New Issue | |
| 2022-09-10 04:46 | Patrick Schmalstig | Note Added: 0007506 | |
| 2022-09-15 01:30 | Chris Graham | Assigned To | => Chris Graham |
| 2022-09-15 01:30 | Chris Graham | Status | non-assigned => resolved |
| 2022-09-15 01:30 | Chris Graham | Resolution | open => fixed |
| 2022-09-15 01:30 | Chris Graham | Note Added: 0007511 | |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
