View Issue Details

IDProjectCategoryView StatusLast Update
0004932Composrcorepublic2022-09-27 17:23
ReporterChris GrahamAssigned ToChris Graham 
SeverityFeature-request 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0004932: Tooltip generation code is a mess
Description"CROP_TEXT_MOUSE_OVER_*" is a confusing term for a tooltip generator, rename to *_TOOLTIP (as we have other *_TOOLTIP functions already so it combines to form a set)
tpl_crop_text_mouse_over is a confusing name for a function for another reason, as the 'tpl_' prefix is nowadays used for template previews not regular functions; rename to generate_tooltip_by_truncation
There are no direct functions for generating the tooltips with set text, add inline_tooltip and block_tooltip - and make generate_tooltip_by_truncation a front-end to them

We should not be using INLINE_TOOLTIP/BLOCK_TOOLTIP templates directly now we have a function

TEXT_LARGE/TEXT_SMALL parameters should be renamed, it may not even be text and 'small' and 'large' is indirect terminology; use TOOLTIP/LABEL

BLOCK_TOOLTIP/block_tooltip used too much, often we may want to use inline_tooltip / Alter generate_tooltip_by_truncation to show the inline tooltips if appropriate

Only use generate_tooltip_by_truncationinline_tooltip/block_tooltip if we cannot use the truncate symbols ($TRUNCATE_*) combined with our normal HTML/JavaScript

symbol_truncator vs generate_tooltip_by_truncation - rationalise why we have these two different functions

generate_tooltip_by_truncation should be able to take Tempcode and/or HTML
TagsRoadmap: v11
Time estimation (hours)3
Sponsorship open

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2022-09-12 15:26 Chris Graham New Issue
2022-09-12 15:26 Chris Graham Status non-assigned => assigned
2022-09-12 15:26 Chris Graham Assigned To => Chris Graham
2022-09-12 15:26 Chris Graham Tag Attached: 3
2022-09-12 15:26 Chris Graham Tag Attached: Roadmap: v11
2022-09-12 15:41 Chris Graham Description Updated View Revisions
2022-09-12 15:42 Chris Graham Description Updated View Revisions
2022-09-12 15:54 Chris Graham Description Updated View Revisions
2022-09-12 18:57 Chris Graham Status assigned => resolved
2022-09-12 18:57 Chris Graham Resolution open => fixed
2022-09-27 17:23 Chris Graham Time estimation (hours) => 3
2022-09-27 17:23 Chris Graham Tag Detached: 3