View Issue Details

IDProjectCategoryView StatusLast Update
0005126Composr alpha bug reports[All Projects] General / Uncategorisedpublic2023-01-02 18:27
ReporterPatrick SchmalstigAssigned ToChris Graham 
SeverityMinor-bug 
Status resolvedResolutionfixed 
Summary0005126: Unread notification bugs
DescriptionThe following issues were found with notifications:

* Viewing (marking read) a single notification does not update / clear the cache of the notifications popup (when you click the bell, the notification still says not read even though it's marked read in digestives_tin... and the bell still has the same number for unread notifications)
* While "mark all read" will update the popup and unread notifications counter, there is still a red 0 for unread notifications until next page load; this should probably be removed instead.
* When receiving a new notification from the poller, a red 0 appears instead of correctly identifying the number of unread notifications.
TagsNo tags attached.
Sponsorship open

Activities

Chris Graham

2022-12-08 18:15

administrator   ~0007787

1) notifications module has this code

            delete_cache_entry('_get_notifications', null, $member_id);

$member_id is the from member. We need the to member. Which is not necessarily the same as get_member() (as an admin could be viewing anyone's notification).

2) core_notifications.js has this code

                $dom.html(spot, $dom.html(display[0]));
                $dom.html(button.firstElementChild, $dom.html(unread[0]));

Which is horrible and needs re-factoring. Pretty sure it's the cause.

Issue History

Date Modified Username Field Change
2022-12-05 18:08 Patrick Schmalstig New Issue
2022-12-05 18:08 Patrick Schmalstig Status non-assigned => assigned
2022-12-05 18:08 Patrick Schmalstig Assigned To => Chris Graham
2022-12-05 18:09 Patrick Schmalstig Description Updated View Revisions
2022-12-08 18:15 Chris Graham Note Added: 0007787
2023-01-02 18:27 Chris Graham Status assigned => resolved
2023-01-02 18:27 Chris Graham Resolution open => fixed
2023-02-26 18:29 Chris Graham Category General => General / Uncategorised