View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005277 | Composr | installer | public | 2023-02-10 03:38 | 2023-02-21 02:43 |
Reporter | Patrick Schmalstig | Assigned To | |||
Severity | Feature-request | ||||
Status | non-assigned | Resolution | open | ||
Product Version | |||||
Fixed in Version | |||||
Summary | 0005277: Separate language selection and integrity checks into separate steps | ||||
Description | The integrity and health checks can take a long time. Some users may be wondering if something is wrong when they first load the installer because no output is being given quickly. My suggestion: 1. Make the first step when running the installer the language selection (since this loads quickly); move all integrity and health checks to the next step (maybe run a bare-bones integrity check on the language files though). 2. Before starting the integrity and health checks, load a page saying something like "Checking your installation environment...". So this step would probably be split into an A and B. A contains the checking environment message and is loaded from language selection. It also contains an immediate redirect to B when the dom is finished (B is what runs the actual checks and displays their outputs). | ||||
Tags | No tags attached. | ||||
Time estimation (hours) | 1 | ||||
Sponsorship open | |||||
|
How long is a long time, and what can we say about the system involved? Linux or Windows? SSD or HDD? For me it is sub-second. It runs a limited permissions check with a specialised version of the scanner. |
|
On my Linux system, it takes about 7 seconds. On my remote Linux server, granted it has older hardware, it takes about 20 seconds. Windows takes about 10 seconds I think on AMPPS, if I recall when I did Windows testing. SSD for both my home Linux and Windows set-ups. HDD for the remote server. |
|
Ok, the slowness has been fixed. The issue is that "Connection: Close" was not being passed in our HTTP sockets implementation for POST requests. Some servers waited longer than others to terminate the connection automatically. This relates to HTTP 1.1 keepalive functionality. That said, I will keep this issue open as there is some merit to the idea of having more clarity about what the checks are, when they are running, and what the results are. The exact flow would probably need to be discussed more. |
|
While the Health Check isn't much of a slow down, the "file integrity check" may be. Although this only runs for the manual installer and auto-skips if too slow. So this is definitely part of the discussion here. |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-02-10 03:38 | Patrick Schmalstig | New Issue | |
2023-02-10 03:38 | Patrick Schmalstig | Description Updated | View Revisions |
2023-02-12 16:03 | Chris Graham | Note Added: 0007912 | |
2023-02-14 21:51 | Patrick Schmalstig | Note Added: 0007914 | |
2023-02-16 17:46 | Chris Graham | Note Added: 0007919 | |
2023-02-21 02:43 | Chris Graham | Note Added: 0007945 |