View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005608 | Composr non-bundled addons | [All Projects] General / Uncategorised | public | 2024-02-12 00:50 | 2024-07-25 19:17 |
| Reporter | Patrick Schmalstig | Assigned To | Patrick Schmalstig | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0005608: Refactor make_release into a proper module admin_make_release (+ additional changes as indicated) | ||||
| Description | Convert the make_release minimodule to an admin_make_release module using language strings instead of hard-coded language text. Use the form template API instead of echoing out everything raw. Also, add in the ability to modify the URLs used during the make_release process (will be necessary for the early stages of v11). | ||||
| Additional Information | The primary reasons why I decided to convert this to a regular module and use language strings are as follows: 1. Better code readability / structure as it is a pretty large module. 2. Support for more than just English. 3. Support for de-branding by using "the software" instead of "Composr". 4. Support for customizing individual steps via translate / rephrase as appropriate. For the time being, all other minimodules for the build addon will be left as minimodules as they either have no sufficient UI or are small in functionality. This will NOT be ported to v10; this will only be for v11. | ||||
| Tags | Roadmap: v11 | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
| related to | 0005609 | assigned | Patrick Schmalstig | Composr build tools | Add unit test for composr_release_build.ini to check target="_blank" |
|
|
I'm dubious about reasons 2-4. I don't see why we would be paying the costs associated with other teams trying to fork Composr. However, if '1' was important, fair enough. |
|
|
It was already done; it worked out for the better because it enabled easier use of specifying custom URLs for the APIs to hit as well as updating the version file. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-02-12 00:50 | Patrick Schmalstig | New Issue | |
| 2024-02-12 00:50 | Patrick Schmalstig | Status | non-assigned => assigned |
| 2024-02-12 00:50 | Patrick Schmalstig | Assigned To | => Patrick Schmalstig |
| 2024-02-12 00:50 | Patrick Schmalstig | Tag Attached: Roadmap: v11 | |
| 2024-02-12 00:50 | Patrick Schmalstig | Additional Information Updated | View Revisions |
| 2024-02-12 03:31 | Patrick Schmalstig | Status | assigned => resolved |
| 2024-02-12 03:31 | Patrick Schmalstig | Resolution | open => fixed |
| 2024-02-12 03:33 | Patrick Schmalstig | Relationship added | related to 0005609 |
| 2024-07-25 19:11 | Chris Graham | Note Added: 0008940 | |
| 2024-07-25 19:17 | Patrick Schmalstig | Note Added: 0008942 |
