View Issue Details

IDProjectCategoryView StatusLast Update
0005894Composrcore_upgraderpublic2024-09-06 10:38
ReporterAdam EdingtonAssigned ToPatrick Schmalstig 
SeverityFeature-request 
Status resolvedResolutionfixed 
Product Version11.beta2 
Fixed in Version 
Summary0005894: Inform of potential .htaccess changes
DescriptionThere is no mention of potential changes to the bundled .htaccess files even in the upgrade tutorial. This could result in end users having out-of-date .htaccess files. It might be useful to add a post-upgrade notice to check plain.htaccess/recommended.htaccess for any relevant changes.
TagsRoadmap: v11
Time estimation (hours)
Sponsorship open

Activities

Patrick Schmalstig

2024-08-17 02:50

administrator   ~0009209

Last edited: 2024-08-17 02:51

View 2 revisions

What I will probably do is have the upgrader check for the presence of a .htaccess file in root. If it exists, an extra step will be added on the UI instructing the user to compare/diff their .htaccess file with recommended.htaccess for any changes that need merging. Or, I may have file integrity scan check for it.

admin

2024-09-05 18:40

administrator   ~0009283

Automated response: Inform of potential .htaccess changes

This patch adds an extra step on the upgrader after file integrity scan if .htaccess exists. It informs the user to compare / diff with recommended.htaccess and merge in any relevant changes.

admin

2024-09-05 18:40

administrator   ~0009284

Fixed in Git commit 1f5da29893 (https://gitlab.com/composr-foundation/composr/commit/1f5da29893 - link will become active once code pushed to GitLab)

admin

2024-09-05 18:40

administrator  

hotfix-5894, 2024-09-05 6pm.tar (51,200 bytes)

admin

2024-09-05 18:40

administrator   ~0009285

A hotfix (a TAR of files to upload) has been uploaded to this issue. Only apply this hotfix if you absolutely need it and cannot wait until the next release of Composr (releases are more reliable and strictly tested). As of Composr version 11, the recommended way to apply a hotfix is by following the same steps as an upgrade (https://baseurl/upgrader.php, use the hotfix on the step “Transfer across new/updated files”). The upgrader will automatically skip files belonging to addons you do not have installed or that are newer on disk than in the hotfix. Otherwise, you can manually extract and replace these files (do not replace if your on-disk file is newer than the one in the hotfix). Always take backups of your site or at least files you are replacing before applying a hotfix. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Patrick Schmalstig

2024-09-05 18:41

administrator   ~0009286

Note: This issue was originally reported for v10. But v10 is only accepting critical bug fixes, so the patch / fix above is for v11. A fix will not be made for v10.

Issue History

Date Modified Username Field Change
2024-08-17 02:38 Adam Edington New Issue
2024-08-17 02:38 Adam Edington Status non-assigned => assigned
2024-08-17 02:38 Adam Edington Assigned To => Patrick Schmalstig
2024-08-17 02:38 Adam Edington Tag Attached: Roadmap: v11
2024-08-17 02:40 Adam Edington Summary Inform of potential .htaccess changes upon upgrade => Inform of potential .htaccess changes
2024-08-17 02:42 Adam Edington Category General / Uncategorised => core_upgrader
2024-08-17 02:42 Adam Edington Description Updated
2024-08-17 02:43 Adam Edington Issue Revision Dropped: Description: 0004521
2024-08-17 02:44 Adam Edington Description Updated View Revisions
2024-08-17 02:44 Adam Edington Issue Revision Dropped: Description: 0004522
2024-08-17 02:46 Adam Edington Tag Detached: Roadmap: v11
2024-08-17 02:48 Adam Edington Tag Attached: Roadmap: v11
2024-08-17 02:50 Patrick Schmalstig Note Added: 0009209
2024-08-17 02:51 Patrick Schmalstig Note Edited: 0009209 View Revisions
2024-09-05 18:41 Patrick Schmalstig Note Added: 0009286