View Issue Details

IDProjectCategoryView StatusLast Update
0000667Composrcns_forumpublic2012-07-10 19:08
ReporterpsydocAssigned ToChris Graham 
SeverityMinor-bug 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0000667: View all emoticons
DescriptionWhen you click the "view all emoticons" link, the iframe opens; however, when you click on an emoticon, it is not added to the textarea dialog box for a comment post.

It does not seem to function on the Composr forums either.

This appears to be a browser compatibility problem as it occurs in Firefox. It functions properly in IE.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

Chris Graham

2012-07-08 20:42

administrator   ~0000745

It seems our technique no longer works in Firefox. We'll change this in the next patch, but a workaround is to make this change in themes/default/templates/JAVASCRIPT_EDITING.tpl...

FROM...

function do_emoticon(field_name,p,_opener)
{
    var element;
    if (_opener)
    {
        element=opener.document.getElementById(field_name);


TO...


function do_emoticon(field_name,p,_opener)
{
    var element;
    if (_opener)
    {
        element=parent.document.getElementById(field_name);

psydoc

2012-07-10 01:03

reporter   ~0000747

Chris, that does not seem to fix the problem. I have checked twice,not including the first modification, and no joy.

Chris Graham

2012-07-10 19:06

administrator   ~0000753

Automated response: Overlay context trick not working on Firefox

Javascript windowing context is altered so overlays look like a popup window -- however this no longer works for Firefox. Therefore the templates need to be changed to analyse the context in-situ.

Chris Graham

2012-07-10 19:07

administrator   ~0000754

Fixed in git commit 11f4887 (https://github.com/chrisgraham/Composr/commit/11f4887 - link will become active once code pushed)

A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Chris Graham

2012-07-10 19:07

administrator  

hotfix-667, 2012-07-10 7pm.tar (159,744 bytes)

Chris Graham

2012-07-10 19:08

administrator   ~0000755

This is the full fix I mentioned on the forum. This will be rolled into the next patch release, due soon.

Issue History

Date Modified Username Field Change