View Issue Details

IDProjectCategoryView StatusLast Update
0000107Composrcore_comcode_pagespublic2013-06-25 14:23
ReporterChris GrahamAssigned ToChris Graham 
SeverityFeature-request 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0000107: Comcode page editing permissions, per zone
DescriptionMake it so the permission tree editor can set specific permissions for individual Comcode pages.

We can add a virtual site tree node to the Permissions Tree Editor encompassing all Comcode pages for a zone.
e.g. "CMS > Comcode Pages > Site"
and allow people to set specific permissions against that. This allows setting of Comcode-page specific permissions in a zone, without it confusing people too much.
Additional InformationIn implementation zones will masquerade as categories under the cms_comcode_pages module. This is pretty much what they are, from this context. Of course, cms_comcode_pages itself exists in a zone, but you don't need to think about that - it's more of something for developers to get their head around.
TagsRisk: Database change
Time estimation (hours)5
Sponsorship open


If users wish to sponsor this issue (optional, some issues are implemented without sponsorship)...
If users wish to sponsor this issue (optional, some issues are implemented without sponsorship)...

Activities

Chris Graham

2012-10-31 02:46

administrator   ~0001041

http://compo.sr/forum/topicview/misc/deploying/page-edit-permission.htm#first_unread

kenno

2013-05-28 19:59

reporter   ~0001467

Once my site is open and I can finance this, I will sponsor some of this, if not the rest that is required.

Chris Graham

2013-05-31 09:38

administrator   ~0001472

Wow, we're sponsored, and by a collaboration of 5 people - that's exciting. Thanks guys, I think development will begin in the next couple of weeks.

Chris Graham

2013-06-02 23:40

administrator  

comcode_zone_control.tar (415,232 bytes)

Chris Graham

2013-06-02 23:41

administrator   ~0001481

Last edited: 2013-06-02 23:44

View 2 revisions

This is now implemented :).

I have attached the changed files for v9.

The changes have been developed in the git comcode_page_permissions branch.

I will leave this issue open until it is merged into v10.

Support credits have been charged - so pleased ignore that this has moved the 'paid up' back down.

Lhasadreams

2013-06-24 17:01

reporter   ~0001516

Excellent - just got around to trying it out.

I created a new page that I wanted a user "y" who is a member of say group "x" to be able to edit and look after.

I then went to the Permissions Tree Editor and gave group "X" "Edit Own Compage" permission for Zone Content Management -> Module CMS_Content_Pages -> Welcome.
Welcome zone is where the new page is.

I then changed the owner ship of the page to user "y" and saved.

The page then reports "Sorry, "y" does not have access to use the 'block' Comcode tag (usage blocked).

This is the same error that i had before this patch was implemented - I have misunderstood what it ois supposed to allow ?

Cheers
Ade

Chris Graham

2013-06-24 17:10

administrator   ~0001517

Last edited: 2013-06-24 17:11

View 2 revisions

Access to add blocks is entirely separate to access to manage Comcode pages.

If you can add a block, that is one of the most dangerous things in Composr. Because, you can configure a block to pretty much access any hidden content on the site.

A page on the other hand, the only real danger in access to edit those is embarrassment potential.

Because the security concept behind block control is separate from Comcode page edit control, it doesn't make sense to try and allow overrides for it. The block privilege, truly is a global concept.

You can turn it on if you trust someone.

That said, newer Composr patches no longer add the main_comcode_page_children block to a page automatically if the person adding that page doesn't have permission to add blocks. So, that is where there's a relationship, and probably the source of your confusion :). You can remove this line from cms/pages/modules/cms_comcode_pages.php: "$contents.=chr(10).chr(10).'[block]main_comcode_page_children[/block]';".

Jean

2013-06-25 14:23

reporter   ~0001519

Thank you for your hard work on seeing this feature through, Chris!
I love the fact that specific permissions can now be attributed to comcode pages. I am sure I will eventually find good use for it.
Great :)

Issue History

Date Modified Username Field Change
2016-06-08 00:15 Chris Graham Tag Renamed Database change => Risk: Database change