View Issue Details

IDProjectCategoryView StatusLast Update
0001821Composrbannerspublic2015-03-09 01:24
ReporterPatrick SchmalstigAssigned To 
SeverityMajor-bug 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0001821: Clicking on a banner results in a PHP critical error
DescriptionClicking on a banner through the Composr banner system results in:

PHP ERROR [1] Call to a member function is_staff() on a non-object in sources/input_filter.php on line 521 (version: 9.0.17, PHP version: 5.4.38, URL: /banner.php?source=&dest=bronysquare&type=click&keep_session=1174567177)

The bug is also present in version 9.0.18 .
Steps To Reproduce1. Create a banner
2. Click the banner when it appears on site
3. You get an Composr critical error bailing out page. The full error reflects PHP call to member function is_staff() on a non-object in sources/input_filter.php on line 521.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

Chris Graham

2015-03-08 22:10

administrator   ~0002609

Automated response: Default field filter not working correctly for banner click script

The field filter is now applied in more circumstances than before, but does not work correctly within the banner click script as that loads a reduced form of Composr that cannot handle the full filter code.

Chris Graham

2015-03-08 22:10

administrator   ~0002610

Fixed in git commit 25f9f2e (https://github.com/chrisgraham/Composr/commit/25f9f2e - link will become active once code pushed to github)

A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

hotfix-1821, 2015-03-08 11pm.tar (22,016 bytes)

Patrick Schmalstig

2015-03-09 01:24

administrator   ~0002611

The issue has been fixed. Thank you!

Issue History

Date Modified Username Field Change