View Issue Details

IDProjectCategoryView StatusLast Update
0002372Composrcorepublic2016-04-04 20:57
ReporterPatrick SchmalstigAssigned ToChris Graham 
Severity@80@ 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0002372: Composr 10RC1: upgrade "failed" miserably; several instability issues
DescriptionThe actual upgrade itself succeeded and looked to me like it went okay. All files transferred and I was able to apply the changes to my code over-rides. However, upon trying to run RC1 on my website, I ran into several issues.

For one, the home page won't even load correctly. It errors with PHP NOTICE [8] Undefined index: p_post__text_parsed in sources/lang.php on line 1156 (version: 10 RC1, PHP version: 5.6.19, URL: /). This error is actually present in the home page of the Admin dashboard as well, and wouldn't be surprised if it's present in other areas as well.

Home page also displays a Javascript error 2287: Uncaught ReferenceError: $ is not defined
https://lovinity.org/ .

Another issue is in-line text editing triggers a massively-huge Javascript error, specifically on editing forum topic titles inline during the test. For example: #0 _generic_exit(Tempcode Object ([code_to_preexecute] => Array ([do_runtime_57020bdf214751.98898020_1] => $tpl_funcs['do_runtime_57020bdf214751.98898020_1']="echo ecv(\$cl,array(),2,\"javascript:NOT_INTEGER\",array());";
),[seq_parts] => Array ([0] => Array ([0] => Array ([0] => do_runtime_57020bdf214751.98898020_1,[1] => Array (),[2] => 2,[3] => javascript:NOT_INTEGER,[4] => ))),[preprocessable_bits] => Array (),[pure_lang] => 1,[evaluate_echo_offset_group] => 0,[evaluate_echo_offset_inner] => 0,[codename] => :container,[preprocessed] => ,[cached_output] => A field that was supposed to be an integer (for our purposes, a whole number between -2147483648 and 2147483647) was not,[children] => ,[fresh] => ), WARN_SCREEN, ) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/global2.php:887]
#1 warn_exit(Tempcode Object ([code_to_preexecute] => Array ([do_runtime_57020bdf214751.98898020_1] => $tpl_funcs['do_runtime_57020bdf214751.98898020_1']="echo ecv(\$cl,array(),2,\"javascript:NOT_INTEGER\",array());";
),[seq_parts] => Array ([0] => Array ([0] => Array ([0] => do_runtime_57020bdf214751.98898020_1,[1] => Array (),[2] => 2,[3] => javascript:NOT_INTEGER,[4] => ))),[preprocessable_bits] => Array (),[pure_lang] => 1,[evaluate_echo_offset_group] => 0,[evaluate_echo_offset_inner] => 0,[codename] => :container,[preprocessed] => ,[cached_output] => A field that was supposed to be an integer (for our purposes, a whole number between -2147483648 and 2147483647) was not,[children] => ,[fresh] => )) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/failure.php:158]
0000002 _param_invalid(id, _73, ) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/global2.php:1604]
0000003 get_param_integer(id) called at [/var/www/vhosts/lovinity.org/httpdocs/forum/pages/modules/topics.php:3348]
0000004 Module_topics->edit_topic()
0000005 call_user_func(Array ([0] => Module_topics Object ([title] => ),[1] => edit_topic)) called at [/var/www/vhosts/lovinity.org/httpdocs/forum/pages/modules/topics.php:221]
0000006 Module_topics->run() called at [/var/www/vhosts/lovinity.org/httpdocs/sources/zones.php:782]
0000007 load_module_page(forum/pages/modules/topics.php, topics, ) called at [/var/www/vhosts/lovinity.org/httpdocs/sources_custom/site.php:1179]
0000008 request_page(topics, 1) called at [/var/www/vhosts/lovinity.org/httpdocs/sources/ajax.php:370]
0000009 fractional_edit_script() called at [/var/www/vhosts/lovinity.org/httpdocs/data/fractional_edit.php:58]
A field that was supposed to be an integer (for our purposes, a whole number between -2147483648 and 2147483647) was not
Additional InformationFailsafe mode was activated on lovinity.org due to the criticality of this issue.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

Chris Graham

2016-04-04 13:21

administrator   ~0003522

I am looking at this now.

Chris Graham

2016-04-04 13:27

administrator   ~0003523

The main crash is now fixed. It was a problem with showing forum topics with posts through the forum driver, caused by a different fix.

I am looking at the JavaScript issue now.

Chris Graham

2016-04-04 13:58

administrator   ~0003524

I have turned off failover mode on your site as it seems okay now.

The inline editing issue will be fixed for RC2.

I am also reviewing your error log.

Chris Graham

2016-04-04 14:11

administrator   ~0003525

I am concerned by the big flood of messages like:

[04-Apr-2016 07:05:15 UTC] PHP Notice: Undefined index: i_caption_text_parsed in /var/www/vhosts/lovinity.org/httpdocs/sources_custom/lang.php on line 1156

All clustered very close to 7AM UTC, but for a number of different *_text_parsed fields.

But I just realised it is in a customised lang.php, and '*_text_parsed' instead of '*__text_parsed', so it was probably a typo in your override.

Chris Graham

2016-04-04 14:12

administrator   ~0003526

In fact, it was probably an attempt to fix what you thought was a typo in the original cause, that you thought caused the original issue here. Sometimes we use '__' instead of '_' just to make a clearer separator from the rest of a name which may itself involve underscores.

Patrick Schmalstig

2016-04-04 20:57

administrator   ~0003527

Yeah I was running a test when that happened. The override should have been removed though.

Issue History

Date Modified Username Field Change
2016-04-04 06:39 Patrick Schmalstig New Issue
2016-04-04 13:21 Chris Graham Note Added: 0003522
2016-04-04 13:27 Chris Graham Note Added: 0003523
2016-04-04 13:51 Chris Graham Status non-assigned => resolved
2016-04-04 13:51 Chris Graham Resolution open => fixed
2016-04-04 13:51 Chris Graham Assigned To => Chris Graham
2016-04-04 13:58 Chris Graham Note Added: 0003524
2016-04-04 14:11 Chris Graham Note Added: 0003525
2016-04-04 14:12 Chris Graham Note Added: 0003526
2016-04-04 20:57 Patrick Schmalstig Note Added: 0003527