View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002407 | Composr | galleries | public | 2016-04-14 15:39 | 2016-04-14 17:24 |
| Reporter | Tig | Assigned To | Chris Graham | ||
| Severity | Minor-bug | ||||
| Status | closed | Resolution | fixed | ||
| Product Version | |||||
| Fixed in Version | |||||
| Summary | 0002407: Gallery images are being rotated in some pages | ||||
| Description | When you 'view image' in the browser, the images are displayed in their correct orientation. However, anything scaled down (we post large images) are rotated. | ||||
| Steps To Reproduce | An example of which is: http://smallgreenpinky.com/index.php?page=galleries&type=image&id=primrose-and-forget-me | ||||
| Tags | No tags attached. | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
Ahh, EXIF orientation isn't being checked before thumbnail or scale down creation, shame. |
|
|
Hi, Could you attach the original image to this issue, just so I'm 100% sure I have the original image to test with. This will likely be related to EXIF rotation of images. Cameras store them in weird ways. |
|
|
Ah, you noticed EXIF yourself - I just noticed your comment, we posted at the same time. In which case, could you tell me if you have the PHP exif support enabled? It should be in the PHP-info. |
|
|
IMG_0212.JPG (2,048,642 bytes) |
|
|
EXIF Support enabled EXIF Version 1.4 $Id$ Supported EXIF Version 0220 Supported filetypes JPEG,TIFF |
|
|
These are taken with an iPhone 6 on iOS 9.3.1 and default camera app, so a reasonable common image source. However, it does use EXIF version 0221 |
|
|
Regression in v10 due to other changes, I'll attach a fixed cms/pages/modules/cms_galleries.php file. |
|
|
cms_galleries.php (130,821 bytes) |
|
|
What's interesting is that I'm having mixed results. For the Gallery view (sub gallery) some images are displaying correctly, others are not. Then when you click through those images, they may (or may not) be rotated The best place to see this happening is: https://smallgreenpinky.com/index.php?page=galleries&type=browse&id=pictures-from-pinky%2Fthe-courts-garden Aubrieta and Tulips thumbnail is correct but is upside down when you click through. Primrose and Forget-me-nots is correct as a thumbnail and flipped when you click through, the same for 'Fringed white tulip' I have been correcting these images and re-uploading but it seems odd that there is a difference between thumbnail and actual display going on. |
|
|
Yes, we have had the EXIF correction code for quite a long time. We changed the name of the upload field in v10 which stopped the code running for the main image, it only ran for the thumbnail. Browser <img> tags don't do EXIF correction, even when EXIF is there - but when you view the image standalone in the browser, the browser does do it. So there was: 1) Correct thumbnails 2) Incorrect full view of images via <img> tag 3) Correct view of the full image standalone in the browser |
|
|
This hasn't actually fixed the issue. |
|
|
You need to reupload the images. |
|
|
Sorry, just realised, I'll need to re-upload the images for new thumbnail creation, forgive me, it's been a long week already. |
|
|
Ok. I deleted the original (the full delete option) then re-uploaded (same title and same picture) and it's still upside down. |
|
|
Could it be your browser cache? If you delete then re-add, it will likely re-use the same disk filename, hence same URL. |
|
|
Worse, guess who forgot he has a transparent proxy at home that STILL needs some tweaking. Yes, all fixed (as I'm certain you realised it would be) Thank you for such a quick response. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-04-14 15:39 | Tig | New Issue | |
| 2016-04-14 15:57 | Tig | Note Added: 0003569 | |
| 2016-04-14 15:57 | Chris Graham | Note Added: 0003570 | |
| 2016-04-14 15:59 | Chris Graham | Note Added: 0003571 | |
| 2016-04-14 16:01 | Tig | File Added: IMG_0212.JPG | |
| 2016-04-14 16:01 | Tig | Note Added: 0003572 | |
| 2016-04-14 16:05 | Tig | Note Added: 0003573 | |
| 2016-04-14 17:06 | Chris Graham | Note Added: 0003575 | |
| 2016-04-14 17:06 | Chris Graham | Status | non-assigned => resolved |
| 2016-04-14 17:06 | Chris Graham | Resolution | open => fixed |
| 2016-04-14 17:06 | Chris Graham | Assigned To | => Chris Graham |
| 2016-04-14 17:07 | Chris Graham | File Added: cms_galleries.php | |
| 2016-04-14 17:08 | Tig | Note Added: 0003576 | |
| 2016-04-14 17:11 | Chris Graham | Note Added: 0003577 | |
| 2016-04-14 17:13 | Tig | Note Added: 0003578 | |
| 2016-04-14 17:14 | Chris Graham | Note Added: 0003579 | |
| 2016-04-14 17:14 | Tig | Note Added: 0003580 | |
| 2016-04-14 17:14 | Tig | Status | resolved => @20@ |
| 2016-04-14 17:14 | Tig | Resolution | fixed => reopened |
| 2016-04-14 17:17 | Tig | Note Added: 0003581 | |
| 2016-04-14 17:17 | Tig | Status | @20@ => assigned |
| 2016-04-14 17:19 | Chris Graham | Note Added: 0003582 | |
| 2016-04-14 17:23 | Tig | Note Added: 0003583 | |
| 2016-04-14 17:24 | Chris Graham | Status | assigned => closed |
| 2016-04-14 17:24 | Chris Graham | Resolution | reopened => fixed |
