View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000288 | Composr | calendar | public | 2011-10-03 10:20 | 2012-02-26 09:58 |
| Reporter | Falko | Assigned To | Chris Graham | ||
| Severity | Feature-request | ||||
| Status | closed | Resolution | fixed | ||
| Product Version | |||||
| Fixed in Version | |||||
| Summary | 0000288: calendar - multi-day events, strange behaviour, some questions | ||||
| Description | Hi. I've found some calendar bugs for multi-day events. E.g. we added an event lasting from 22:38, 29 September 2011 up to 23:38, 03 October 2011, but it is not constantly displayed in the calendar over the entire period. I uploaded some pictures to show you this ... 001 - 29 & 30 September OK 002 - 01, 02 & 03 October missing 003 - day view 29 October OK 004 - day view 30 September, 01, 02 & 03 October missing 005 - week view 29, 30 September & 01 October OK, 02 & 03 October missing 006 - year view: displayed only once on 29 October And I have two further questions for you: How could I change the short form (e.g. Mon, Tue, Wed ...) on the side panel listing (marked red in 001) to long form (e.g. Monday, Tuesday, Wednesday)? I've found the {TIME*} expression in the BLOCK_SIDE_CALENDAR_LISTING.tpl, but I don't know how to use/change it. Is there a possibilty to create an all-day event without start time or a all-day multi-day event without start and end time? Best regards Falko | ||||
| Tags | No tags attached. | ||||
| Time estimation (hours) | 4 | ||||
| Sponsorship open | |||||
|
|
|
|
|
I've forgot: I'm using Composr 7.1.5 :) |
|
|
Showing the full spans is not supported in all cases, for performance and code complexity reasons. I think 'Mon' is a language string. Times are not optional, you'd just need to decide e.g. to start at 9am or midnight. |
|
|
Depending on the price, maybe we could solve the issues via paid support? Including everything I wrote in the first post. But then it should be implemented in future versions of Composr, too. A good calendar function would be important for our community development. ______________________________________ Regarding to the language string: The {TIME*} expression in the BLOCK_SIDE_CALENDAR_LISTING.tpl causes short names such "Mon, Tue, Wed ...". But I want to display the long names now such as "Monday, Tuesday, Wednesday ...". How to make this change? Best regards Falko |
|
|
I reckon it would be roughly 3 hours work. If you think you can stretch to that, I'll give it some more thought. I really do need to ensure that it is not going to add some big inefficiency in doing a full analysis between all time regions. It might, or might not, I'm not 100% sure at this point. --- I was wrong about language strings. It is hardcoded in sources/blocks/side_calendar.php. Change "'D'" to "'l'" (i.e. single quotes are there). Line 146. It would be nice if this went through a language string like the other time "equations" do. In fact, I will do that for the next release. |
|
|
Ack, I think I am talking rubbish about side_calendar.php. Bear with me... |
|
|
Change date_withinweek_date language string from %a to %A. |
|
|
Yeah, the last one did the job. Thanks :) When I tried to pay via PayPal, I had to pay 20 percent (about 30 EUR) value added tax additional. Is it possible to transfer you the the 110 GBP (about 130 EUR) directly? After that I will prepare a concrete list of changes I would like you to implement :) Best regards Falko |
|
|
Ah, I should have turned VAT off already, as we're not currently registered. I hadn't noticed as most online business comes from outside Europe. That's now done. However... I need to confirm I am actually able to implement this for you, I don't want you to send money then come back and say there are big problems. I think it will be fine, but I will confirm later today :). |
|
|
|
|
|
Hi Chris, additional to my first suggestions, some more details, what I would like you to implement: - a multi-day event should displayed for every day in side calendar block (picture 001) |- why it isn't displayed in this order: Freitag, Samstag, Sonntag, 10. Oktober (2011)? |- Info: week begins on sunday is unset - End (Date and Time) should be unset by default (picture 002) - maybe you could add a tickbox for multi-day events like in Mozilla lightning (picture 003) :) - display the birthdays of members in calendar (not side block) Hopefully I don't annoy you and you will understand what I write. I uploaded a second attachement. Best regards Falko |
|
|
Hi, Yes I can now confirm all this can be done. The extra points will put it up to 4 hours. Would you like me to proceed? |
|
|
FYI Your birthdays request would be implementation of 0000007. That was down as 3 hours, but I have said 1 extra hour because I reckon I can do it more efficiently seeing as I'm already looking at making other changes at the same time. I am also considering throwing in point 4 from 0000048 (more specification of timezones), as it is a popular request. |
|
|
Well, I bought 25 credits now. When you could connect the improvements with 0000007 and 0000048 this would be great. I'm most interested in automatic DST. Up to now I always had to do it manually. Just to be sure, the improvements will be slip in the official version of Composr? Thanks for all your hard work. Best regards Falko |
|
|
Great :). I'm working on some of it now for you should be done this week. I will try and send both a set of changed files for you, and yes it will be in 7.2. Regarding automatic DST, if I understand you correctly this is already in Composr in recent versions. The calendar stuff is to make it specific what timezone an event is for. Some events shouldn't have timezone conversions and just say the direct requested time and timezone (e.g. birthdays), other events should auto-convert to the timezone the viewer is in (e.g. webinars). |
|
|
|
|
|
modified-files.zip contains the changes. I am concerned it may not be compatible with 7.1, particularly the sources/form_templates.php file. It is just the 'form_input_date' function that I have changed in that file. All will be included in 7.2. You definitely got some value for money, ended up taking about 10 hours rather than 4 ;). But nice changes, you will have made a few people happy with this. |
|
|
Thank you so much Chris. Our community look forward to the new features :) Best regards Falko |
|
|
Hey Chris, I started to test the new calendar features with the yesterdays v8. And I want to give you some bug reports now. At first I made a short video (without sound) showing some issues: http://vimeo.com/37231967 The next point is about some theme modifications. I attached a picture to demonstrate how it should looks like. I'm especially not lucky with the side calendar listing block. A multi-day event should only be displayed once with the small info symbol. And maybe it would be better if you could remove the outer left image by default. It's just wasting space. Times should only be displayed if set in the event. What's bringing me to the next point. After adding an all day event it is displayed everywhere with the time 12:00 AM. So it isn't really an all day event. This confuses me. Best regards Falko |
|
|
|
|
|
Working through this now. One note: "And maybe it would be better if you could remove the outer left image by default. It's just wasting space." That's the event type icon. You can template out if you like. |
|
|
For the record I've just improved our vcalendar support a bit-- it's now working on the side_calendar listing block, and supports end date/time. |
|
|
Fixed in https://github.com/chrisgraham/Composr/commit/990051ec1b4a55e815607b82e93ec46d368c8c52 |
|
|
Hey Chris, unfortunately I have to reopen the topic again. I've found a lot of more issues (sorry for that) and made again some videos (this time with sound). Hopefully you will understand what I'm trying to say :o I want to start with an event set across two month: http://vimeo.com/37399800 - 0000004 The "unmonitor" button: http://vimeo.com/37399966 - 0000005 A multi-day event starts before the current date: http://vimeo.com/37400202 - 0000006 calendar side block: http://vimeo.com/37401540 - 0000007 Probably you will already curse the calendar ;) But it's a very important feature for my projects. Best regards Falko |
|
|
"Hopefully you will understand what I'm trying to say :o" I can very easily :). My only comment... I always correct people who say "two-thousand-and-twelve" and get them to say "twenty-twelve". We're 12 years into the millenium and using really long year names still :D. Just kidding. |
|
|
Regarding "A multi-day event starts before the current date:". What actually happened here was this... When you view an event, the date of that event is held in the URL, because of recurrences it needs to know which "instance" of the event it was. When you edited, it took you back to the same URL. We'll fix by stopping that automatic redirect back, as it's taking you back to a defunct URL. |
|
|
Got all this sorted except one issue now. I haven't committed yet though. |
|
|
Fixes all committed. That last issue was very complex. |
