View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003188 | Composr | core_rich_media | public | 2017-04-05 14:13 | 2019-06-30 20:13 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Product Version | |||||
| Fixed in Version | |||||
| Summary | 0003188: Allow disabling the feature where deleted attachments automatically get put back | ||||
| Description | If you attach a file, then delete the Comcode reference for it, then preview (without reloading the whole editor), it comes back at the end of the post. This is an intentionally feature for people who accidentally (or intentionally) erase attachments from the post, but do actually still want it on the end (like a normal 'attachment' might be expected to be). Currently the feature auto-disables for simplified-attachments-UI. Make an option so you have full control of it. I think either setting may confuse people, it's very much personal preference. | ||||
| Additional Information | This code: } elseif ((!browser_matches('simplified_attachments_ui')) && (strpos($comcode, ']new_' . $matches[1] . '[/attachment]') === false) && (strpos($comcode, ']new_' . $matches[1] . '[/attachment_safe]') === false)) { if (preg_match('#\]\d+\[/attachment\]#', $comcode) == 0) { // Attachment could have already been put through (e.g. during a preview). If we have actual ID's referenced, it's almost certainly the case. $comcode .= "\n\n" . '[attachment]new_' . $matches[1] . '[/attachment]'; } } | ||||
| Tags | Roadmap: v11 | ||||
| Time estimation (hours) | 0.4 | ||||
| Sponsorship open | |||||
|
|
I've just removed the auto-restoration feature. I don't think anyone would really want it, especially because JS is now assumed on, there's no good reason for the attachment code to go missing without the user doing it intentionally. If it is a user-error, the user will learn. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-04-05 14:13 | Chris Graham | New Issue | |
| 2019-06-27 18:01 | Chris Graham | Tag Attached: Roadmap: v11 | |
| 2019-06-30 20:13 | Chris Graham | Assigned To | => Chris Graham |
| 2019-06-30 20:13 | Chris Graham | Status | non-assigned => resolved |
| 2019-06-30 20:13 | Chris Graham | Resolution | open => fixed |
| 2019-06-30 20:13 | Chris Graham | Note Added: 0006014 |
