View Issue Details

IDProjectCategoryView StatusLast Update
0003219Composrcore_comcode_pagespublic2017-04-13 20:19
ReporterAdam EdingtonAssigned ToChris Graham 
SeverityFeature-request 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0003219: Comcode page children issues
DescriptionThe first issue is in the codename for child pages (which 'has' to be numbers and letters). The codename of my first page was map1-1, which shows up in the list of children but fails to link to the page. I then tried map1_1 (as I was sure the underscores used to be allowed) and got the same result as above. If it's strictly alphanumeric then maybe a check of the codename before accepting it would be useful.

My third attempt was map1x1, which I managed to link to. However the h1 of all the comcode pages has ended up sharing space with the breadcrumbs. Maybe I need to enable the setting for comcode page hierarchy, but for a new user this might be confusing. Certainly the codename for pages shouldn't accept characters the link URL doesn't like.
Additional InformationGit install from about 2 weeks ago.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

Adam Edington

2017-04-13 13:22

administrator  

h1 placement.png (8,676 bytes)
h1 placement.png (8,676 bytes)

Chris Graham

2017-04-13 14:16

administrator   ~0004987

I believe I fixed this last week.

As for breadcrumbs, if fixed width is off there's more space so the CSS is coded to put them side-by-side with title.

It's always been tricky as what is best really depends on the site, if it has panels, the length of titles, the breadcrumb depth.

In global.css

.global_breadcrumbs {
    padding: 7px 0 7px 0;
    /*{+START,IF,{$NOT,{$MOBILE}}}*/
        /*{+START,IF,{$CONFIG_OPTION,fixed_width}}*/
            text-align: {!en_right};
        /*{+END}*/
        /*{+START,IF,{$NOT,{$CONFIG_OPTION,fixed_width}}}*/
            float: {!en_right};
        /*{+END}*/
        margin-left: 0.5em;
    /*{+END}*/
}

change to

.global_breadcrumbs {
    padding: 7px 0 7px 0;
    /*{+START,IF,{$NOT,{$MOBILE}}}*/
        text-align: {!en_right};
        margin-left: 0.5em;
    /*{+END}*/
}

Adam Edington

2017-04-13 17:18

administrator   ~0004988

Ahh okay, that makes sense. Well the other thing I wanted to mention is the idea of sectioning the breadcrumbs using the colon. So basically anything that appears after the : is not included in the breadcrumb. So if a page was called 'Tutorial 1: How to manually edit breadcrumbs', you would just see Tutorial 1 in the breadcrumbs.

Chris Graham

2017-04-13 20:09

administrator   ~0004989

You can do with a couple of template changes.

Templates:
BREADCRUMB_LINK_WRAP, BREADCRUMB_LONE_WRAP

{LABEL*}
-->
{$PREG_REPLACE,:.*$,,{LABEL*}}

I wouldn't want to do by default. People may have multiple pages in a hierarchy sharing a prefix intentionally.

Adam Edington

2017-04-13 20:19

administrator   ~0004990

I wouldn't have realised that such a simple change would do this. Thanks.

Issue History

Date Modified Username Field Change
2017-04-13 13:22 Adam Edington New Issue
2017-04-13 13:22 Adam Edington File Added: h1 placement.png
2017-04-13 14:16 Chris Graham Note Added: 0004987
2017-04-13 14:16 Chris Graham Status non-assigned => resolved
2017-04-13 14:16 Chris Graham Resolution open => fixed
2017-04-13 14:16 Chris Graham Assigned To => Chris Graham
2017-04-13 17:18 Adam Edington Note Added: 0004988
2017-04-13 20:09 Chris Graham Note Added: 0004989
2017-04-13 20:19 Adam Edington Note Added: 0004990