View Issue Details

IDProjectCategoryView StatusLast Update
0003446Composr alpha bug reports[All Projects] General / Uncategorisedpublic2017-12-12 19:47
ReporterChris GrahamAssigned ToSalman 
SeverityFeature-request 
Status resolvedResolutionfixed 
Summary0003446: Tray expander images seem to be breaking hi-dpi
DescriptionThe 'theme_images' test is failing...

Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/contract at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/contract2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/expand at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme default: 2x/trays/expand2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/contract at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/contract2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/expand at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]
Fail: theme_images_test_set -> testBrokenReferences -> Unused theme image in theme admin: 2x/trays/expand2 at [/Library/WebServer/Documents/composr/_tests/tests/unit_tests/theme_images.php line 171]

Looking at the JS code, I can't see it using srcset anymore.


We shouldn't be upscaling/downscaling with low quality blending code, we have (until we switch to SVGs anyway) separate optimised images for normal-dpi and high-dpi.
TagsNo tags attached.
Sponsorship open

Activities

Salman

2017-12-12 19:47

reporter   ~0005306

I think I had removed the srcset assignments due to a bug, added them back now.

Issue History

Date Modified Username Field Change
2017-12-05 04:20 Chris Graham New Issue
2017-12-05 04:20 Chris Graham Status non-assigned => assigned
2017-12-05 04:20 Chris Graham Assigned To => Salman
2017-12-12 19:47 Salman Note Added: 0005306
2017-12-12 19:47 Salman Status assigned => resolved
2017-12-12 19:47 Salman Resolution open => fixed
2023-02-26 18:29 Chris Graham Category General => General / Uncategorised