View Issue Details

IDProjectCategoryView StatusLast Update
0003449Composr[All Projects] General / Uncategorisedpublic2017-12-19 04:12
ReporterJoeAssigned ToChris Graham 
SeverityMajor-bug 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0003449: Can't modify profile with Facebook-auth on MSN
DescriptionTrying to modify the profile of a Facebook login results in the following error message:


Please check back over the form - you did not fill in all fields on the form correctly

Even though all fields are set correctly. No fields are marked as "required".

The Ensure completed profiles is disabled on both sites. I thought this was causing the issue but it is not.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

Chris Graham

2017-12-07 20:21

administrator   ~0005295

I would need a link to a site to see this on.
My suspicion is there's something on one of the other sub-tabs. All the sub-tabs need to be filled in correctly as the form spans all of them - this sometimes confuses people.

Joe

2017-12-08 11:27

reporter   ~0005296

Chris,

I've noticed I've got some serious issues on my end. I was trying to create a new Facebook-side account to my website and got some MySQL errors. So at this point I cannot even register new users to try and duplicate the profile editing issue.

At this point I'm just going to do a fresh install. I've been meaning to do this anyways as I've been getting numerous errors throughout my site lately.

If this still doesn't fix the issue I'll let you know.

Thanks

Chris Graham

2017-12-08 16:23

administrator   ~0005298

Often MySQL issues can be fixed with a table repair.

I'm genuinely willing and eager to look into almost any issue, so long as I can easily see it and it's not someone else's custom code. Usually I can reproduce things on my own, but if it's going to take me an hour to make a test environment and I'm not certain that'll even reproduce a bug it's best to let me access your own site (if you can of course).

Joe

2017-12-14 01:29

reporter   ~0005310

Chris,

After a fresh install, the issue still persists but only seems to affect Facebook logins. I've opened the site for you, please let me know when you've tested so I can reclose the site (as its still under dev)

You should be able to create a FB account.

https://bosslife.org

Chris Graham

2017-12-14 04:47

administrator   ~0005311

Hi,

Your FB app is in development mode - you'll need to make my Facebook Account, chris@ocproducts.com, a registered tester on the app.

Nice theme btw.

Joe

2017-12-14 10:54

reporter   ~0005312

Thank you Sir.

I added your username, ocpchris, to the registered testers. Let me know if you have any other issues.

admin

2017-12-14 20:44

administrator   ~0005313

Automated response: Error saving profiles if using the Facebook addon

If e-mail address and/or DOB is set to required in the Composr settings it will fail, as these are also marked non-editable within the Facebook code.

admin

2017-12-14 20:44

administrator   ~0005314

Fixed in git commit 1c294e8eb (https://github.com/ocproducts/composr/commit/1c294e8eb - link will become active once code pushed to github)

A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Chris Graham

2017-12-14 20:44

administrator   ~0005315

Please try this attached hot-fix. It is speculative, but once I realised it was a server-side issue, I was able to examine the code.
(Previously I'd assumed it was client-side).

Joe

2017-12-14 23:22

reporter   ~0005316

Seems to be working fine, other than the fact that I'm able to initially change the email address and username associated with the FB account, but once I logout and back in again, these are both reverted back to their original state.

If it's possible to edit these and have them keep their values, than that's cool, but I don't expect to be able to. If these values cannot be changed (which I'm fine with), maybe we can just hide these fields from being editable entirely?

Joe

2017-12-14 23:24

reporter   ~0005317

Also, I thought I read in the documentation somewhere that a FB account could be converted by changing their password? Yet this field isn't directly editable.

Chris Graham

2017-12-15 01:17

administrator   ~0005318

Rats, those fields were not supposed to re-appear. I changed sources/cns_field_editability.php in the TAR. Please upload that file and test again (re-test saving too).

"Also, I thought I read in the documentation somewhere that a FB account could be converted by changing their password? Yet this field isn't directly editable." - no, by password reset (the lostpassword module)

Joe

2017-12-15 03:57

reporter   ~0005319

They're still appearing on my end.

Chris Graham

2017-12-19 02:10

administrator  

hotfix-3449%252C 2017-12-14 8pm.tar (133,120 bytes)

Chris Graham

2017-12-19 02:10

administrator   ~0005321

Please try now.

Joe

2017-12-19 04:12

reporter   ~0005322

We're good. Thanks!

Issue History

Date Modified Username Field Change
2017-12-06 18:19 Joe New Issue
2017-12-07 20:21 Chris Graham Note Added: 0005295
2017-12-07 20:21 Chris Graham Status non-assigned => closed
2017-12-07 20:21 Chris Graham Assigned To => Chris Graham
2017-12-07 20:21 Chris Graham Resolution open => unable to reproduce
2017-12-08 11:27 Joe Note Added: 0005296
2017-12-08 16:23 Chris Graham Note Added: 0005298
2017-12-14 01:29 Joe Note Added: 0005310
2017-12-14 04:47 Chris Graham Note Added: 0005311
2017-12-14 10:54 Joe Note Added: 0005312
2017-12-14 20:44 Chris Graham Note Added: 0005315
2017-12-14 23:22 Joe Note Added: 0005316
2017-12-14 23:24 Joe Note Added: 0005317
2017-12-15 01:16 Chris Graham File Deleted: hotfix-3449, 2017-12-14 8pm.tar
2017-12-15 01:16 Chris Graham File Added: hotfix-3449%2C 2017-12-14 8pm.tar
2017-12-15 01:17 Chris Graham Note Added: 0005318
2017-12-15 03:57 Joe Note Added: 0005319
2017-12-19 02:05 Chris Graham File Deleted: hotfix-3449%2C 2017-12-14 8pm.tar
2017-12-19 02:05 Chris Graham File Added: hotfix-3449%252C 2017-12-14 8pm.tar
2017-12-19 02:10 Chris Graham File Deleted: hotfix-3449%252C 2017-12-14 8pm.tar
2017-12-19 02:10 Chris Graham File Added: hotfix-3449%252C 2017-12-14 8pm.tar
2017-12-19 02:10 Chris Graham Note Added: 0005321
2017-12-19 04:12 Joe Note Added: 0005322
2023-02-26 18:29 Chris Graham Category General => General / Uncategorised