View Issue Details

IDProjectCategoryView StatusLast Update
0003467Composrcorepublic2019-06-27 18:57
ReporterChris GrahamAssigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status non-assignedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0003467: Support Unicode BOM markers
DescriptionMake functions to insert BOM markers into text files, and to strip them and convert to the correct character set.

cms_file_put_contents_safe and cms_file_get_contents_safe should have bitmask options for using this processing.

Every fopen call should also be reviewed.

And every HTTP call.

Search the code for this pattern to make sure the code is converted to use the new functions:
chr(hexdec('EF')) . chr(hexdec('BB')) . chr(hexdec('BF'))

Additional Informationhttps://en.wikipedia.org/wiki/Byte_order_mark
TagsRoadmap: v11
Attach Tags
Time estimation (hours)3
Sponsorship open

Relationships

related to 0003032 non-assigned Bulletproof spreadsheet importing 

Activities

Chris Graham

2018-02-19 02:09

administrator   ~0005528

Last edited: 2018-03-01 19:43

View 2 revisions

We also need to add coding standards. I think we have one about line endings already, add about supporting/stripping BOMs properly, and about making any of our own files ASCII (so charset independent). Document the new rule that we can assume any of our own files (i.e. not user-modifiable) will not need any extra checks.

Also add ones relating to 0003032.

EDIT: Partly done in "Code formatting" part of codebook_standards.

Issue History

Date Modified Username Field Change
2017-12-26 19:34 Chris Graham New Issue
2018-02-07 20:44 Chris Graham Relationship added related to 0003032
2018-02-13 02:37 Chris Graham Description Updated View Revisions
2018-02-19 02:09 Chris Graham Note Added: 0005528
2018-03-01 19:43 Chris Graham Note Edited: 0005528 View Revisions
2019-06-27 18:57 Chris Graham Tag Attached: Roadmap: v11