View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003526 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2018-02-02 02:29 | 2018-02-06 06:08 |
| Reporter | Chris Graham | Assigned To | Salman | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Summary | 0003526: $util.srl must be used consistently | ||||
| Description | The screenshot shows it is not. $util.srl is important for sites that run both HTTPS and HTTP. There are practical situations where we have sites like this. For example, legacy iframes that only support HTTP. If running a reverse proxy, Composr will not know which is running, so we cannot stop the exact same JS being served. We therefore need to strip the protocol, as your $util.srl function does. | ||||
| Tags | No tags attached. | ||||
| Sponsorship open | |||||
|
|
Screen Shot 2018-02-02 at 02.19.19.png (893,771 bytes) |
|
|
I have updated tut_tempcode to better explain the point of: - $BASE_URL_NOHTTP - $FIND_SCRIPT_NOHTTP - $IMG used in conjunction with $util.srl In all cases it allows provides when running both HTTPS and HTTP together. In the case of $FIND_SCRIPT_NOHTTP it also provides safety for multi-domain environments. |
|
|
To provide some further context... Composr uses absolute URLs throughout, to radically simplify things, such as not having to be knowing where you're relative to, the need for portable context-free code, and the need for PHP itself to call up URLs outside any context. This is fine and dandy in all situations except JS, which has it's various sandboxing limitations. |
|
|
Fixed by https://github.com/ocproducts/composr/commit/6808c50844db063cc1a0dda2171c38cbb1eca8f0 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-02-02 02:29 | Chris Graham | New Issue | |
| 2018-02-02 02:29 | Chris Graham | File Added: Screen Shot 2018-02-02 at 02.19.19.png | |
| 2018-02-02 02:29 | Chris Graham | Status | non-assigned => assigned |
| 2018-02-02 02:29 | Chris Graham | Assigned To | => Salman |
| 2018-02-02 02:34 | Chris Graham | Note Added: 0005419 | |
| 2018-02-02 02:36 | Chris Graham | Note Added: 0005420 | |
| 2018-02-02 02:37 | Chris Graham | Note Edited: 0005420 | View Revisions |
| 2018-02-06 06:08 | Salman | Note Added: 0005443 | |
| 2018-02-06 06:08 | Salman | Status | assigned => resolved |
| 2018-02-06 06:08 | Salman | Resolution | open => fixed |
| 2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |
