View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003536 | Composr | quizzes | public | 2018-02-10 02:15 | 2018-02-13 00:07 |
Reporter | Joe | Assigned To | Chris Graham | ||
Severity | Feature-request | ||||
Status | resolved | Resolution | fixed | ||
Product Version | |||||
Fixed in Version | |||||
Summary | 0003536: Comcode output conflict in QUIZ_DONE_SCREEN.tpl | ||||
Description | When creating or editing a quiz, the "Questions" field supports Comcode. Comcode is displayed as expected on QUIZ_SCREEN.tpl (when taking the test) However, on the completion page (QUIZ_DONE_SCREEN.tpl), output ignores all Comcode and displays as normal text. | ||||
Tags | No tags attached. | ||||
Time estimation (hours) | |||||
Sponsorship open | |||||
related to | 0003539 | resolved | Chris Graham | Tests should not score questions with no defined correct answer |
|
I should add: I used Comcode in both the question and the explanation. On QUIZ_DONE_SCREEN.tpl where it lists the explanation as to why the answer was incorrect, this is when the output issue occurs. |
|
I am not able to reproduce. I put in Comcode for absolutely everything and it parsed correctly. I'm also not entirely clear what I'm looking at. The issue says "Comcode is displayed as expected on QUIZ_SCREEN.tpl" [implying it's on the question and/or answer text] but also said "On QUIZ_DONE_SCREEN.tpl where it lists the explanation as to why the answer was incorrect, this is when the output issue occur" [implying it's on the explanation test]. I think you probably mean the question and/or answer (as that's all that shows on both), but I'm not 100% on that. A screenshot would help. It may not even quite by the Comcode not parsing, it could be something like auto-escaping of HTML happening due to a code override, so escaped-parsed-Comcode might be shown. |
|
|
|
|
|
|
|
Screens added |
|
I tried changing line 19 of QUIZ_DONE_SCREEN.tpl... From: {CORRECTIONS}{AFFIRMATIONS} To: {$COMCODE,{CORRECTIONS}{AFFIRMATIONS}} But this has no positive impact on the output. |
|
quiz_fixes.tar (44,032 bytes) |
|
Thanks. I see it was only when reveal answers was off, that's what I was missing. I think you edited some of the language strings, e.g. QUIZ_MISTAKE_EXPLAINED_COMCODE, to not show the answer. I've made the same edit myself, as I didn't consider it correct to show the answer when reveal answers was off, only the explanation. I tweaked a few other things, mainly commenting my code better, as it was a bit muddled. |
|
Hot-fix is attached. |
|
And the main commit: https://github.com/ocproducts/composr/commit/2ae99510febf19de99cbb861723cce94768bcb91 |
|
Chris, Not sure if this is supposed to happen, but here's a scenario: 1. I'm taking a 'Test' and have one or more fields that require input (such as [SHORT]) 2. This field doesn't have a correct or incorrect answer 3. Entering a value in this field always results in failing the test (assuming I set a passing score of 100%) Users should only be SCORED on questions that have a correct answer (otherwise marked with [*]). Not all tests will have a correct answer, and it would be nice to ask questions (like "how are you today?") without penalizing the test taker. |
|
I will add a new issue for this. It's important each tracker issue covers just one thing, or at least a very closely related family of things. |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-02-10 02:15 | Joe | New Issue | |
2018-02-10 02:17 | Joe | Note Added: 0005488 | |
2018-02-11 21:40 | Chris Graham | Note Added: 0005497 | |
2018-02-11 22:39 | Chris Graham | Resolution | open => suspended |
2018-02-12 00:53 | Joe | File Added: quiz1.png | |
2018-02-12 00:53 | Joe | File Added: quiz2.png | |
2018-02-12 00:53 | Joe | File Added: quiz3.png | |
2018-02-12 00:55 | Joe | Note Added: 0005502 | |
2018-02-12 00:58 | Joe | Note Added: 0005503 | |
2018-02-12 02:30 | Chris Graham | Status | non-assigned => resolved |
2018-02-12 02:30 | Chris Graham | Assigned To | => Chris Graham |
2018-02-12 02:31 | Chris Graham | Resolution | suspended => fixed |
2018-02-12 02:33 | Chris Graham | File Added: quiz_fixes.tar | |
2018-02-12 02:34 | Chris Graham | Note Added: 0005504 | |
2018-02-12 02:34 | Chris Graham | Note Added: 0005505 | |
2018-02-12 02:35 | Chris Graham | Note Added: 0005506 | |
2018-02-12 23:18 | Joe | Note Added: 0005510 | |
2018-02-13 00:06 | Chris Graham | Note Added: 0005512 | |
2018-02-13 00:07 | Chris Graham | Relationship added | related to 0003539 |