View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003817 | Composr | core | public | 2019-06-10 18:07 | 2021-02-28 05:05 |
| Reporter | Chris Graham | Assigned To | Chris Graham | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Product Version | |||||
| Fixed in Version | |||||
| Summary | 0003817: Ensure we are using web font loader with Google Fonts | ||||
| Description | We must not have any Google Fonts blocking the critical rendering path. Google does provide a solution for this: https://www.lockedownseo.com/load-google-fonts-asynchronously-for-page-speed/ | ||||
| Tags | Roadmap: v11, Type: Performance | ||||
| Time estimation (hours) | 2 | ||||
| Sponsorship open | |||||
|
|
Implemented using the official JS API for this, which we're now bundling. It's use is controlled via a config option, as there's a tradeoff involved. Basically with JS loading you have the font show later, but with no potential for blocking the critical rendering path. I've explained this in the option's help. I did look at other possibilities, mainly: 1) Just bundle Google Font .ttf files (or whatever) directly 2) Write our own deferred loading code 3) Do the trick where you say media="none" onload="this.media='screen';" 4) Whether there's a defer attribute on the <link> tag yet 5) Whether the <link> tag can just be put at the end of the HTML 1) A lot of messing about and you lose the advantage of Google's CDN and a shared cache pool and Google's ability to customise output CSS based on user agent 2) Better to use official lib, they must have made it for a reason too, probably manages network traffic well 3) Not possible with CSP. We would have to either allow inline JS, or have some very ugly <script> tag in our <head>, or write some complex code to try and detect if a <link> tag was loaded yet which is possibly unreliable. And it relies on the browser supporting dynamically changing the media attribute. Also see 2. 4) There's not. 5) Invalid HTML. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-06-10 18:07 | Chris Graham | New Issue | |
| 2019-06-10 18:07 | Chris Graham | Tag Attached: 1 | |
| 2019-06-10 18:07 | Chris Graham | Tag Attached: Type: Performance | |
| 2019-06-27 17:32 | Chris Graham | Tag Detached: 1 | |
| 2019-11-15 22:07 | Chris Graham | Tag Attached: Roadmap: v11 | |
| 2019-11-15 22:07 | Chris Graham | Assigned To | => Salman |
| 2019-11-15 22:07 | Chris Graham | Status | non-assigned => assigned |
| 2021-02-28 05:05 | Chris Graham | Assigned To | Salman => Chris Graham |
| 2021-02-28 05:05 | Chris Graham | Status | assigned => resolved |
| 2021-02-28 05:05 | Chris Graham | Resolution | open => fixed |
| 2021-02-28 05:05 | Chris Graham | Note Added: 0006977 |
