View Issue Details

IDProjectCategoryView StatusLast Update
0003977Composrcore_addon_managementpublic2019-12-07 14:53
ReporterAdamAssigned ToChris Graham 
Severityminor 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version10.0.29 
Summary0003977: Exporting and importing addons
DescriptionI have noticed that:-

1) When exporting addons that no config files is created and if one is included in the export the details entered no longer overwrite the existing file so it doesn't matter what you type. (Edit: I meant the addon_registry not config, and I realise the export details go in addon.inf but I am sure those details used to create/update the addon_registry file).

2) When importing, after deleting an addon and seeing all the files marked as deleted, there are some files left behind (in my case a language file and an image in data_custom). Also when installing an addon, it seems the css and js files included are not listed though they are installed and present in the addon_registry file).
TagsNo tags attached.
Attach Tags
Time estimation (hours)
Sponsorship open

Activities

Adam

2019-12-05 19:54

administrator  

uninstall.png (46,867 bytes)
uninstall.png (46,867 bytes)
install.png (56,006 bytes)
install.png (56,006 bytes)

Chris Graham

2019-12-07 01:15

administrator   ~0006205

Ok, what this boils down to is the addon export tool is originally designed for addons with no registry hook, and addon.inf was supreme. Actually there were no such thing as a registry hook when the addon management was originally implemented.
Since then, registry hooks are used to identify how addons within the git repository and bundled addons are composed. They are not needed, but it's a tidy way to do things.

I have made some changes...

1) If you select a registry hook when choosing files for your addon, it will pre-populate the fields that go into addon.inf, and you will be advised to not change them. (I don't want us to be dynamically rewriting the registry hooks).
2) If you select *only* the registry hook, it will automatically select all other files referenced in that hook.
3) If you select a registry hook but a different set of files to what is mentioned in the hook, it will exit with an error message.

This way, you can essentially defer to what the registry hook is saying when exporting addons.

I have tested uninstall an addon and didn't find any issues, other than the filenames were poorly sorted. I can see inconsistency in filenames between your 2 screenshots, so that probably explains it - you were probably debugging, or inconsistent with how you defined your addon files (the first part of this problem). Once an addon is installed, the registry hook does take precedence, so there's definitely scope for inconsistency prior to me resolving this issue.

Adam

2019-12-07 13:33

administrator   ~0006206

Last edited: 2019-12-07 14:53

View 1 revisions

I noticed the different filename on the image shortly after, sorry, but I think it was left behind (or removed and marked as will be overwritten upon reinstallation) before I renamed the file also. Thanks for the changes though, brilliant.

Issue History

Date Modified Username Field Change
2019-12-05 19:50 Adam New Issue
2019-12-05 19:50 Adam File Added: uninstall.png
2019-12-05 19:50 Adam File Added: install.png
2019-12-05 19:51 Adam File Deleted: uninstall.png
2019-12-05 19:51 Adam File Deleted: install.png
2019-12-05 19:54 Adam File Added: uninstall.png
2019-12-05 19:54 Adam File Added: install.png
2019-12-05 21:32 Adam Description Updated View Revisions
2019-12-07 01:15 Chris Graham Assigned To => Chris Graham
2019-12-07 01:15 Chris Graham Status non-assigned => resolved
2019-12-07 01:15 Chris Graham Resolution open => fixed
2019-12-07 01:15 Chris Graham Note Added: 0006205
2019-12-07 13:33 Adam Note Added: 0006206
2019-12-07 14:53 Adam Note Edited: 0006206 View Revisions
2019-12-07 14:54 Adam Note Revision Dropped: 6206: 0002749