View Issue Details

IDProjectCategoryView StatusLast Update
0004064Composrcorepublic2020-01-29 02:39
ReporterChris GrahamAssigned ToChris Graham 
Severitytrivial 
Status resolvedResolutionfixed 
Product Version10.0.29 
Fixed in Version10.0.30 
Summary0004064: Behaviour of XHTML cleanup code is inconsistent with HTML5 cleanup algorithm
DescriptionHTML5 cleans up self-closing tags that are not meant to be self-closing by stripping the self-closing, and then injects the closing of still-open tags while it finds that the next closer is not a match to the last thing opened.

The Composr XHTML cleanup tool leaves the self-closer alone.

This inconsistency may lead to confusion with AJAX-loaded HTML - which gets pre-cleaned by Composr because the AJAX JavaScript needs it to be XML-compliant. "Why are tags self-closing in one situation but not the other" a user may ask.

Give the Composr cleanup tool the same behaviour, which requires knowledge of which HTML tags are not meant to self-close.
TagsNo tags attached.
Attach Tags
Time estimation (hours)
Sponsorship open

Activities

admin

2020-01-29 02:39

administrator   ~0006330

Fixed in git commit b004243a1 (https://gitlab.com/composr-foundation/composr/commit/b004243a1 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) have been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

hotfix-4064, 2020-01-29 2am.tar (93,184 bytes)

Issue History

Date Modified Username Field Change