View Issue Details

IDProjectCategoryView StatusLast Update
0004204Composrcorepublic2020-04-24 21:09
ReporterChris GrahamAssigned ToChris Graham 
Severitymajor 
Status resolvedResolutionfixed 
Product Version10.0.30 
Fixed in Version10.0.31 
Summary0004204: Various problems with welcome e-mails
DescriptionUpon user testing and code review, a number of issues have been found with welcome e-mails:
1) Preview will show errors about missing Tempcode parameters (if e-mails have not been disabled on the website)
2) A hard dependency on the newsletters addon exists when it should not
3) If the newsletter template has been given a full HTML wrapper, welcome e-mails won't work...
4) ... and the preview would look bad
5) The unsubscribe URLs in the e-mails are not clickable
6) And the unsubscribe wording refers to newsletters instead of member accounts
7) Previews do not show parameter substitution working, and thus are low quality

These issues are now fixed and the code has been restructured to be cleaner.

In addition, support for referencing any f_members row fields, or f_member_custom_fields row fields, is now supported, for some greater flexibility.
E.g.
"{m_username}" to reference the username.
TagsNo tags attached.
Attach Tags
Time estimation (hours)
Sponsorship open

Activities

admin

2020-04-24 02:48

administrator   ~0006507

Fixed in git commit 069efc584 (https://gitlab.com/composr-foundation/composr/commit/069efc584 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Chris Graham

2020-04-24 21:09

administrator   ~0006509

Updated hot-fix.

hotfix-4204, 2020-04-24 2am.tar (8,908,288 bytes)

Issue History

Date Modified Username Field Change
2020-04-24 21:09 Chris Graham File Deleted: hotfix-4204, 2020-04-24 2am.tar
2020-04-24 21:09 Chris Graham File Added: hotfix-4204, 2020-04-24 2am.tar
2020-04-24 21:09 Chris Graham Note Added: 0006509