View Issue Details

IDProjectCategoryView StatusLast Update
0004250Composrcore_notificationspublic2020-05-27 00:21
ReporterChris GrahamAssigned ToChris Graham 
Severitytrivial 
Status resolvedResolutionfixed 
Product Version10.0.30 
Fixed in Version10.0.31 
Summary0004250: Failure finishing sending notifications on some server/Composr configurations
DescriptionIf:
 - The "Use a task queue" config option is off (the default)
 - CGI timeout is turned on in server settings
 - Lots of notifications are going to send
 - Sending an e-mail through the server sendmail backend is slow / SMTP e-mail is enabled
(the last 3 points correspond - shorter timeout means less time to send each email - more emails means longer timeout needed, etc etc)

Mail will not finish sending.
As tasks are run at the end of the main page view that triggers the task (a notifications task in this case), the user will not see any timeout happening. And because it's a CGI-triggered timeout, PHP doesn't log any kind of error either.

Enabling the task queue resolves the issue as tasks will be processed via Cron in an orderly way rather than in the web request that originally triggers them.

This fix will make it so that if the task queue is not enabled then the e-mails are queued rather than being instantly sent out.
i.e. if one queue is not enabled, it enforces the other
TagsNo tags attached.
Attach Tags
Time estimation (hours)
Sponsorship open

Activities

admin

2020-05-22 02:25

administrator   ~0006561

Fixed in git commit 55b8cfce8 (https://gitlab.com/composr-foundation/composr/commit/55b8cfce8 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Chris Graham

2020-05-27 00:21

administrator   ~0006562

I deleted the hotfix as the initial fix was wrong. However, the hotfix is just the latest sources/notifications.php from git.

Issue History

Date Modified Username Field Change
2020-05-22 02:26 Chris Graham Description Updated View Revisions
2020-05-27 00:21 Chris Graham File Deleted: hotfix-4250, 2020-05-22 2am.tar
2020-05-27 00:21 Chris Graham Note Added: 0006562