View Issue Details

IDProjectCategoryView StatusLast Update
0004326Composrcorepublic2020-07-24 02:50
ReporterChris GrahamAssigned ToChris Graham 
SeverityMinor-bug 
Status resolvedResolutionfixed 
Product Version10.0.31 
Fixed in Version10.0.32 
Summary0004326: ImageMagick should be configurable
DescriptionComposr may call ImageMagick in some cases: as to prevent PHP memory running out when producing large thumbnails, or converting 8-bit PNG files to 32-bit PNG files to avoid a bug present on some PHP installs.

However, on review the autodetection for ImageMagick has some issues:
1) Does not work on Windows
2) Assumes that an executable named 'convert' is ImageMagick, which is not safe (reviewing Linux distributions it 100% always is, but custom apps may have their own conflicting executable which may not even exist when called by PHP).
3) The latest version of ImageMagick has renamed their executable to 'magick' for the above reason. Current detection would not find it.

Make it fully configurable.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

admin

2020-07-24 02:46

administrator   ~0006656

Fixed in git commit 5f03a8071 (https://gitlab.com/composr-foundation/composr/commit/5f03a8071 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Chris Graham

2020-07-24 02:50

administrator  

hotfix-4326, 2020-07-24 2am.tar (481,280 bytes)

Issue History

Date Modified Username Field Change
2020-07-24 02:49 Chris Graham Project Composr non-bundled addons => Composr
2020-07-24 02:49 Chris Graham Category General => core
2020-07-24 02:49 Chris Graham Description Updated View Revisions
2020-07-24 02:49 Chris Graham File Deleted: hotfix-4326, 2020-07-24 2am.tar
2020-07-24 02:50 Chris Graham File Added: hotfix-4326, 2020-07-24 2am.tar