View Issue Details

IDProjectCategoryView StatusLast Update
0004532Composrcorepublic2020-12-27 03:07
ReporterChris GrahamAssigned ToChris Graham 
SeverityMinor-bug 
Status resolvedResolutionfixed 
Product Version10.0.34 
Fixed in Version10.0.35 
Summary0004532: Potential missing lang string error
DescriptionIf a menu item title has all caps and no spaces, and its page-link matches exactly the page-link of a node in the Sitemap, it may assume its a language string incorrectly and use that to override a sitemap caption.

Also if it correctly does get a lang string match from somewhere else (? - this is complex), it may not handle this correctly in the caching.
Additional InformationThese bugs are a bit unclear. They were found in code review, not in the wild. The sitemap code is very complex, especially when combined with caching.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

admin

2020-12-27 03:05

administrator   ~0006874

Fixed in git commit 0ae8af13f (https://gitlab.com/composr-foundation/composr/commit/0ae8af13f - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

admin

2020-12-27 03:06

administrator  

hotfix-4532, 2020-12-27 3am.tar (8,761,344 bytes)

Issue History

Date Modified Username Field Change
2020-12-27 03:07 Chris Graham Description Updated View Revisions
2020-12-27 03:07 Chris Graham Additional Information Updated View Revisions