View Issue Details

IDProjectCategoryView StatusLast Update
0004912Composrcorepublic2022-12-28 03:07
ReporterChris GrahamAssigned To 
SeverityFeature-request 
Status non-assignedResolutionopen 
Product Version 
Fixed in Version 
Summary0004912: Field input: Consider whether a blank value should be considered the same as a missing value
DescriptionCurrently the post_param_string/get_param_string functions treat missing values differently to blank values.

A missing value triggers an error, unless a default value is provided (or null is set as the default).

A blank value is acceptable as a value unless the original form said it was a required field (handled via require__<name> fields).

We ideally should not rely on require__<name> being set on the form. May be we should just remove the above distinction and decouple the validation on the frontend from the validation on the backend.

Then again, doing so may create unexpected problems, and it removes the ability for the frontend to set the validation to subsequently happen on the frontend.

On balance I say we remove the distinction and work out any kinks caused by it later.
TagsRoadmap: Over the horizon
Time estimation (hours)0.5
Sponsorship open

Relationships

related to 0005206 resolvedChris Graham Bots submitting blank member contact form is irksome 
related to 0004913 resolvedChris Graham Better validation of blank input data 

Activities

Chris Graham

2022-12-28 03:07

administrator   ~0007846

I just had to make a workaround related to this issue: https://gitlab.com/composr-foundation/composr/commit/a26e9baaec

Issue History

Date Modified Username Field Change
2022-08-30 20:51 Chris Graham New Issue
2022-08-30 20:51 Chris Graham Status non-assigned => assigned
2022-08-30 20:51 Chris Graham Assigned To => Chris Graham
2022-08-30 20:51 Chris Graham Tag Attached: Roadmap: v11
2022-08-30 20:53 Chris Graham Relationship added related to 0004913
2022-11-20 02:54 Chris Graham Tag Attached: Roadmap: v12
2022-11-20 02:55 Chris Graham Tag Detached: Roadmap: v11
2022-11-20 03:07 Chris Graham Assigned To Chris Graham =>
2022-11-20 03:07 Chris Graham Status assigned => non-assigned
2022-12-28 03:07 Chris Graham Note Added: 0007846
2022-12-28 03:07 Chris Graham Relationship added related to 0005206
2024-03-26 00:58 Patrick Schmalstig Tag Renamed Roadmap: v12 => Roadmap: Over the horizon