View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005189 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2022-12-21 18:00 | 2022-12-23 01:38 |
Reporter | Patrick Schmalstig | Assigned To | Chris Graham | ||
Severity | Minor-bug | ||||
Status | resolved | Resolution | fixed | ||
Summary | 0005189: jumping comcode tag does not work on pages (but does in previews) | ||||
Description | The jumping comcode tag does not work on the actual comcode page (but it does in previews). Seems the "parts" template parameter is not getting added, and I don't understand why. Everything checks out in comcode_renderer.php lines 1216-1231 ($_parts has the expected values in them). | ||||
Tags | No tags attached. | ||||
Sponsorship open | |||||
|
I can't reproduce this. |
|
Here's the div. "parts" is supposed to be an array parameter in the template (in this case, with 3 items), but it doesn't exist, causing a console error. It exists in the preview. |
|
Fixed in https://gitlab.com/composr-foundation/composr/-/commit/6d7b7347778059991377d3053cf6bec2af4751ed Very difficult bug. When a template was first compiled, Composr would detect various parameters were not used and not bind those parameters in the do_template call. However, parameters referenced in the PARAMS_JSON were not considered used. Probably was a big bug happening in many places, surprised we only just found it. |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-12-21 18:00 | Patrick Schmalstig | New Issue | |
2022-12-21 18:00 | Patrick Schmalstig | Status | non-assigned => assigned |
2022-12-21 18:00 | Patrick Schmalstig | Assigned To | => Chris Graham |
2022-12-22 01:05 | Chris Graham | Note Added: 0007830 | |
2022-12-22 16:32 | Patrick Schmalstig | File Added: Screenshot_20221222_113144.png | |
2022-12-22 16:32 | Patrick Schmalstig | Note Added: 0007831 | |
2022-12-23 01:38 | Chris Graham | Note Added: 0007833 | |
2022-12-23 01:38 | Chris Graham | Status | assigned => resolved |
2022-12-23 01:38 | Chris Graham | Resolution | open => fixed |
2023-02-26 18:29 | Chris Graham | Category | General => General / Uncategorised |