View Issue Details

IDProjectCategoryView StatusLast Update
0005218Composr alpha bug reports[All Projects] General / Uncategorisedpublic2023-01-01 20:08
ReporterPatrick SchmalstigAssigned ToChris Graham 
SeverityTrivial-bug 
Status resolvedResolutionfixed 
Summary0005218: Previews: mass_select_delete_form and mass_select_marker are blank
Descriptionmass_select_delete_form and mass_select_marker previews are blank.

mass_select_delete_form has a display: none. And mass_select_marker has a conditional in the template which is not satisfied (thus does not display) for previews.
TagsNo tags attached.
Sponsorship open

Activities

Chris Graham

2023-01-01 20:08

administrator   ~0007855

These can be previewed in tpl_preview__block_main_gallery_embed. The marker appears when overlaying a media item. The form appears when ticking one.

Yes, usually the templates behind mass_select_delete_form/mass_select_marker aren't visible. This is by design (literally, design) to keep them low-key. But other designs may do differently so they do need to be previewable.

That said, viewing these screen previews out of context is pointless. The correct thing is to formally define them as previewed under tpl_preview__block_main_gallery_embed, and then adjusting the _template_previews test to not demand the template actually be used in the preview it says it is used in.

I've done a big reworking and tidy up of how/what we are defining as ones that don't need explicit previews, what is shown as full screen, what is shown as code, etc.

Issue History

Date Modified Username Field Change
2022-12-29 23:58 Patrick Schmalstig New Issue
2022-12-29 23:58 Patrick Schmalstig Status non-assigned => assigned
2022-12-29 23:58 Patrick Schmalstig Assigned To => Chris Graham
2023-01-01 20:08 Chris Graham Status assigned => resolved
2023-01-01 20:08 Chris Graham Resolution open => fixed
2023-01-01 20:08 Chris Graham Note Added: 0007855
2023-02-26 18:29 Chris Graham Category General => General / Uncategorised