View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005401 | Composr alpha bug reports | [All Projects] General / Uncategorised | public | 2023-09-05 21:25 | 2024-09-13 03:13 |
| Reporter | Patrick Schmalstig | Assigned To | Chris Graham | ||
| Severity | Minor-bug | ||||
| Status | assigned | Resolution | open | ||
| Summary | 0005401: Broken URLs: Some status codes determined broken when they are not | ||||
| Description | The broken URL checker determines many status codes as "broken", but some of these statuses are not actually "broken". For example: * 403 forbidden - Composr labels broken, but this could mean login required (IMO though 403 should continue to be broken because the correct status code when login is required should be 401 unauthorized). * 302 Redirect - Composr labels this as broken, but 302 simply means redirection. Composr should probably follow the redirect instead (up to 10 redirects) and use the status of the final URL. | ||||
| Tags | Roadmap: Over the horizon | ||||
| Sponsorship open | |||||
|
|
Upon further thought, this should probably be given special considerations: a) We would generally want all links returning 401 or 403 to be flagged as broken if the link was posted on a publicly facing section of the Composr site (e.g. can be viewed by Guest). For example, links in the docs / tutorials would definitely want to be flagged as broken if they return 401 or 403 because such links should be viewable by the general public. And if not, we should consider removing or changing the link. b) However, when a link is posted in a restricted section of a Composr site that is not viewable by Guest, such as a forum, we might not want broken URL checking to flag a link returning 401 or 403 as broken. For example, a user might post a direct link to a Tweet on X, but X requires everyone to log in before they can view a Tweet. This does not necessarily mean that the link is "broken", it just means it is not "public". And therefore, a non-public link posted in a non-public section of Composr probably should not be flagged as broken if it throws a forbidden status. c) Redirects: Actually, these should probably also be flagged as broken in certain cases. For instance, links posted in the docs / tutorials should definitely be flagged as broken if they return a redirect. That way, developers are informed of the stale link and are then encouraged to get the updated link and update the tutorials / docs accordingly. But any links posted on a Composr site itself which throw a redirect, except maybe for public links that can be viewed by Guest, probably should not be flagged as broken. While they may appear wrong on the site as they will have the old link, clicking on them will simply take the user to the new page. Though, we also need to consider that some websites will use redirects instead of 404 not found when trying to access a post or blog that no longer exists. |
|
|
This is a generalised response to a pattern I am seeing in a number of issues: This should be under the main "Composr" project with a severity of "Feature-request". I can understand why someone may want more control/functionality/clarity from the tool than they are getting, but that's a gap between desire and implementation, not a bug. The feature is operating as designed. Even if someone is correct in identifying a feature is useless to everyone as it isn't doing enough for anyone, it still doesn't follow that improving that feature should be considered a bug fix - other options would include removing the feature entirely, or documenting its limitations and the need for investment. Extending functionality is a broader planning process to be had outside of the context of bug fixing, and should be subject to that, not slipped through as feature creep. |
|
|
I was under the impression this was not working as it was designed for the indicated status codes. Due to this issue, the broken URL notifications get populated very quickly if anyone links things that require login (such as anything on X). |
|
|
Oh, we're talking about Comcode? I thought we were talking about the standalone tool. I'd agree checking in Comcode should have a much higher bar for "broken". |
|
|
I'm not sure. It's whatever creates the notifications for it. I believe Health Check. Comcode does the same thing though. |
|
|
Right. That makes more sense to me. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-09-05 21:25 | Patrick Schmalstig | New Issue | |
| 2023-09-05 21:25 | Patrick Schmalstig | Status | non-assigned => assigned |
| 2023-09-05 21:25 | Patrick Schmalstig | Assigned To | => Patrick Schmalstig |
| 2023-12-22 23:23 | Patrick Schmalstig | Note Added: 0008139 | |
| 2023-12-22 23:23 | Patrick Schmalstig | Assigned To | Patrick Schmalstig => Chris Graham |
| 2024-03-24 19:14 | Chris Graham | Note Added: 0008421 | |
| 2024-03-25 17:02 | Patrick Schmalstig | Note Added: 0008439 | |
| 2024-03-27 13:41 | Chris Graham | Note Added: 0008459 | |
| 2024-03-27 13:59 | Patrick Schmalstig | Note Added: 0008464 | |
| 2024-03-28 14:03 | Chris Graham | Note Added: 0008470 | |
| 2024-09-13 03:13 | Patrick Schmalstig | Tag Attached: Roadmap: Over the horizon |
