View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005441 | Composr | catalogues | public | 2023-11-12 21:07 | 2023-12-14 22:55 |
| Reporter | Patrick Schmalstig | Assigned To | Patrick Schmalstig | ||
| Severity | Minor-bug | ||||
| Status | resolved | Resolution | fixed | ||
| Product Version | 10.0.43 | ||||
| Fixed in Version | 10.0.44 | ||||
| Summary | 0005441: Similar submission conflict detection does not prevent creation of catalogue | ||||
| Description | When creating a new catalogue, if similar submission error is triggered, the catalogue is already created (so proceeding results in an error saying the catalogue already exists). The catalogue should not be created until after proceed is clicked. | ||||
| Additional Information | Probably has to do with auto-creating categories... I think the similar submission is for the categories in my case at which point the catalogue was already created... and proceeding tries to re-create the entire catalogue instead of the category which triggered the error. I think "similar submission" should not be checked for auto-creating categories. | ||||
| Tags | No tags attached. | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
Might have to do with creating a catalogue category via the new catalogue screen. |
|
|
This bug is not fixable: * The double submission check looks in the action logs. But the action logs do not map category to catalogue. Therefore, double submission cannot compare based on catalogue to prevent this bug. * We also cannot do a direct database check for an existing category because titles are stored as translation IDs. This means we would have to translate every row in order to do a check to see if the title exists. * We probably cannot use a redirect hack to prevent this bug (e.g. create the catalogue first, then redirect to another actualiser for creating the categories); this will break the do-next schema. * Finally, we cannot simply remove the double submission check; it's the only guard we have against making categories with the same name (though a very bad one as it's still very possible to do, not that it would break anything though because they would have different IDs). Also worth noting that this gets even more complicated when factoring in child categories. |
|
|
Possibly could use set_mass_import_mode (set positive before creating category, negative afterwards, make sure double submission respects it) |
|
|
Automated response: Similar submission conflict detection does not prevent creation of catalogue When creating a new catalogue, if similar submission error is triggered, the catalogue is already created (so proceeding results in an error saying the catalogue already exists). This fix sets mass import mode on when creating a catalogue with auto_fill categories to prevent this from happening. |
|
|
Fixed in git commit 6b2091a52d (https://gitlab.com/composr-foundation/composr/commit/6b2091a52d - link will become active once code pushed to GitLab) A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). hotfix-5441, 2023-12-14 10pm.tar (120,832 bytes) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-11-12 21:07 | Patrick Schmalstig | New Issue | |
| 2023-11-12 21:07 | Patrick Schmalstig | Note Added: 0008033 | |
| 2023-11-12 21:08 | Patrick Schmalstig | Note Edited: 0008033 | View Revisions |
| 2023-11-12 21:12 | Patrick Schmalstig | Additional Information Updated | View Revisions |
| 2023-11-12 21:13 | Patrick Schmalstig | Additional Information Updated | View Revisions |
| 2023-12-02 01:01 | Patrick Schmalstig | Assigned To | => Patrick Schmalstig |
| 2023-12-02 01:01 | Patrick Schmalstig | Status | non-assigned => closed |
| 2023-12-02 01:01 | Patrick Schmalstig | Resolution | open => not fixable |
| 2023-12-02 01:01 | Patrick Schmalstig | Note Added: 0008078 | |
| 2023-12-02 01:04 | Patrick Schmalstig | Note Edited: 0008078 | View Revisions |
| 2023-12-02 01:05 | Patrick Schmalstig | Note Edited: 0008078 | View Revisions |
| 2023-12-10 16:30 | Patrick Schmalstig | Note Added: 0008115 | |
| 2023-12-10 16:31 | Patrick Schmalstig | Status | closed => non-assigned |
| 2023-12-10 16:31 | Patrick Schmalstig | Resolution | not fixable => reopened |
