View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005496 | Composr | [All Projects] General / Uncategorised | public | 2023-12-09 19:07 | 2024-11-12 17:25 |
| Reporter | Patrick Schmalstig | Assigned To | Chris Graham | ||
| Severity | Minor-bug | ||||
| Status | assigned | Resolution | open | ||
| Product Version | |||||
| Fixed in Version | |||||
| Summary | 0005496: _backups unit test is broken | ||||
| Description | The _backups unit test is broken. It needs mysql root to create the test database to restore into. When I tried modifying the unit test to put that in the _config.php file (at the end) within the backup exports, this did not work. It still tried to use the other non-root username. I also tried moving this config file temporarily to the main config file when running the restore iterations, thinking it was using the main config file and not the one in the test folder. But I was wrong; it was trying to use the test folder config, so that did not work either. This unit test needs careful re-review. For the time being, it's low priority because admins are encouraged to use their web panel for backups instead. | ||||
| Tags | Roadmap: Over the horizon | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
For reference this test is triple-underscore prefixed, meaning it's not necessarily expected to work. Sounds like it is making some unneeded or undocumented assumptions though, which should be corrected. |
|
|
I believe I changed it to triple-underscore some time after making this issue. I changed the semantic meaning of underscores. No = standard test, can run concurrently Single = Slower test, can run concurrently but only in single-thread Double = Slower test / messes with settings or could break other tests. Cannot run concurrently. Should be run sparingly. Triple = Must be run via command line. Cannot run concurrently. Should be run sparingly. Tests not expected to pass are indicated as such in comments inside the files. |
|
|
FYI the above is no longer true... We now have separate directories... first_tests, cli_tests, async_tests, and sync_tests. The underscore semantics are as follows: None = Expected to pass, and should be run on every patch, minor, and major release. Single underscore = Expected to pass but may need special consideration. Should be run on every minor and major release, but not necessary for patch releases. Double underscore = Not expected to pass and needs careful review. Should be run on every major release. Not necessary for minor or patch releases. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-12-09 19:07 | Patrick Schmalstig | New Issue | |
| 2023-12-09 19:07 | Patrick Schmalstig | Status | non-assigned => assigned |
| 2023-12-09 19:07 | Patrick Schmalstig | Assigned To | => Chris Graham |
| 2024-07-31 19:12 | Chris Graham | Note Added: 0009023 | |
| 2024-07-31 20:41 | Patrick Schmalstig | Note Added: 0009027 | |
| 2024-09-13 03:39 | Patrick Schmalstig | Tag Attached: Roadmap: Over the horizon | |
| 2024-11-12 17:25 | Patrick Schmalstig | Note Added: 0009564 |
