View Issue Details

IDProjectCategoryView StatusLast Update
0005501Composrcorepublic2024-09-13 02:56
ReporterAdam EdingtonAssigned ToPatrick Schmalstig 
SeverityTrivial-bug 
Status assignedResolutionopen 
Product Version10.0.43 
Fixed in Version 
Summary0005501: Group language fluency
DescriptionWhen joining a private group you are informed that "Staff" will validate your request. When you proceed you are informed that "Staff / Group leader" will validate your request. This is fine, but perhaps editing the language string for initial join screen which mentions only "Staff" to instead say "your request to join the group will need to be validated" would be preferable to adding "Group leader" so the screens are consistent?
TagsRoadmap: v11
Time estimation (hours)
Sponsorship open

Activities

Patrick Schmalstig

2023-12-13 15:49

administrator   ~0008122

Yeah, I agree we need to be more consistent. I'll make the change, thank you.

Patrick Schmalstig

2023-12-14 23:08

administrator   ~0008128

I'm deferring this issue to a later patch release. It will require careful code / performance consideration.

Adam Edington

2023-12-17 19:15

administrator   ~0008133

It's just removing Staff from the "your application will be validated" text on the initial group screen. The next screen is then not confusing as it lists both staff/usergroup leader may validate.

Patrick Schmalstig

2023-12-18 20:23

administrator   ~0008134

Last edited: 2023-12-18 20:25

View 3 revisions

The way the language strings are used / decided on in the module is a bit more complex than what appears. I'm debating whether it's better to follow your suggestion and just use a generic "your application will be reviewed", or if it should specify the group leader (or "staff" if there is none) as it does when applying for a usergroup. Ideally, I want to do the latter as it is the most consistent, but it would require special considerations in the code because it doesn't currently load in group leader information for that screen (thus it would be a slight performance hit to do it).

Adam Edington

2023-12-19 14:06

administrator   ~0008137

Okay, I just wanted to make it clearer what I meant as I know I can sometimes be vague or open to interpretation.

Issue History

Date Modified Username Field Change
2023-12-13 11:26 Adam Edington New Issue
2023-12-13 15:49 Patrick Schmalstig Note Added: 0008122
2023-12-13 15:50 Patrick Schmalstig Assigned To => Patrick Schmalstig
2023-12-13 15:50 Patrick Schmalstig Status non-assigned => assigned
2023-12-14 23:08 Patrick Schmalstig Note Added: 0008128
2023-12-17 19:15 Adam Edington Note Added: 0008133
2023-12-18 20:23 Patrick Schmalstig Note Added: 0008134
2023-12-18 20:24 Patrick Schmalstig Note Edited: 0008134 View Revisions
2023-12-18 20:25 Patrick Schmalstig Note Edited: 0008134 View Revisions
2023-12-19 14:06 Adam Edington Note Added: 0008137
2024-09-13 02:56 Patrick Schmalstig Tag Attached: Roadmap: v11