View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005564 | Composr | core_upgrader | public | 2024-01-18 23:19 | 2024-11-24 00:48 |
| Reporter | Patrick Schmalstig | Assigned To | Patrick Schmalstig | ||
| Severity | Feature-request | ||||
| Status | resolved | Resolution | fixed | ||
| Product Version | |||||
| Fixed in Version | |||||
| Summary | 0005564: Disassociate Composr version from database / addons / cns versions | ||||
| Description | Currently, the upgrader uses the major on-disk version of Composr to determine if a database upgrade is needed. This is not ideal because it does not allow us to easily apply database fixes or changes as necessary until the next major version of Composr. Separate this out starting with the first release of Composr 11 alpha. The database schema has its own version (we'll start with 11) which is taken from a new, separate version in version.php. And we should compare this with a new value or something in the database to see if the database schema has changed and people should run the database upgrader. The "rebuild sql files" tick should be moved from step 2 to step 1 in the make_release script (when we ask for Composr version). When ticked, the schema version is auto-increased 1 number in version.php. Mention this on the screen. Wherever we are relying on the Composr version to determine how to upgrade the database (e.g. cns_install or anywhere we do not have a block / module / addon version we are using), instead use the database schema version from now on. Or ideally we should create a new info function and give it its own version (starting from 11). Document this where applicable. Mention that the database schema version should be bumped and the sql files rebuilt whenever we make any changes to install functions within Composr or its bundled addons (excludes non-bundled addons). And we should bump the version accordingly of whatever module / block / addon we were working on / made the change (this should already be documented, but check in case). | ||||
| Tags | Roadmap: Over the horizon, Roadmap: v11 partial implementation | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
|
|
You can't just use patch release-level version number checks? |
|
|
That's possible, but wouldn't the installer then think every new patch version means you have to upgrade the database even if there are no upgrades to be done? |
|
|
This is partially resolved... done for the database. I see no current need to do this for addons or cns. |
|
|
Marking as resolved as the current system seems to work |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-18 23:19 | Patrick Schmalstig | New Issue | |
| 2024-01-18 23:19 | Patrick Schmalstig | Status | non-assigned => assigned |
| 2024-01-18 23:19 | Patrick Schmalstig | Assigned To | => Patrick Schmalstig |
| 2024-01-18 23:20 | Patrick Schmalstig | Description Updated | View Revisions |
| 2024-01-18 23:22 | Patrick Schmalstig | Tag Attached: Roadmap: v11 | |
| 2024-01-19 00:05 | Chris Graham | Note Added: 0008204 | |
| 2024-01-19 03:49 | Patrick Schmalstig | Note Added: 0008205 | |
| 2024-01-19 03:49 | Patrick Schmalstig | Note Edited: 0008205 | View Revisions |
| 2024-03-30 03:30 | Patrick Schmalstig | Note Added: 0008485 | |
| 2024-03-30 03:30 | Patrick Schmalstig | Tag Detached: Roadmap: v11 | |
| 2024-03-30 03:30 | Patrick Schmalstig | Tag Attached: Roadmap: v11 partial implementation | |
| 2024-03-30 03:30 | Patrick Schmalstig | Tag Attached: Roadmap: Over the horizon | |
| 2024-03-30 03:30 | Patrick Schmalstig | Project | Composr alpha bug reports => Composr |
| 2024-03-30 03:51 | Patrick Schmalstig | Category | General / Uncategorised => core_upgrader |
| 2024-11-24 00:48 | Patrick Schmalstig | Status | assigned => resolved |
| 2024-11-24 00:48 | Patrick Schmalstig | Resolution | open => fixed |
| 2024-11-24 00:48 | Patrick Schmalstig | Note Added: 0009676 |
