View Issue Details

IDProjectCategoryView StatusLast Update
0005574Composrcorepublic2024-02-09 04:11
ReporterAdam EdingtonAssigned ToPatrick Schmalstig 
SeverityTrivial-bug 
Status resolvedResolutionfixed 
Product Version10.0.44 
Fixed in Version10.0.45 
Summary0005574: Pagination loading issue (not jumping to top after click)
DescriptionWhen selecting additional pages of content, it loads up the next page but doesn't seem to list the items from the top. Rather the page is focused on where the pagination is. Perhaps the pagination should be above the results if this is the behaviour, or whatever the best remedy is.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

admin

2024-01-25 23:56

administrator   ~0008249

Automated response: 5574: Pagination loading issue (not jumping to top after click)

window.scrollTo and smooth_scroll sometimes would not scroll if they were called before the DOM was ready. In the instance of pagination, this meant after clicking on a number and the results loaded, the page would sometimes not scroll up to the top of the results.

I added a 25 millisecond timeout to most scroll calls where I thought it is possible the DOM is not yet ready. This seems to have done the trick for pagination. Hopefully it also resolves the same issue on the upgrader screen where it lists the progress of transferring over files.

admin

2024-01-25 23:56

administrator   ~0008250

Fixed in git commit 0d4b6cee01 (https://gitlab.com/composr-foundation/composr/commit/0d4b6cee01 - link will become active once code pushed to GitLab)

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

hotfix-5574, 2024-01-25 11pm.tar (214,016 bytes)

Patrick Schmalstig

2024-01-25 23:56

administrator   ~0008251

May need porting to v11 as well

Adam Edington

2024-01-29 12:07

administrator   ~0008270

Fixed in v11

Patrick Schmalstig

2024-01-29 17:25

administrator   ~0008272

Awesome to hear.

Patrick Schmalstig

2024-02-09 03:31

administrator   ~0008296

This issue still seems to exist in the v11 upgrader. But it appears what is happening is the scrolling is targeting _top instead of _self.

Issue History

Date Modified Username Field Change
2024-01-24 09:48 Adam Edington New Issue
2024-01-24 09:48 Adam Edington Description Updated View Revisions
2024-01-24 09:48 Adam Edington Issue Revision Dropped: Description: 0003983
2024-01-25 23:53 Patrick Schmalstig Summary Pagination loading issue => Pagination loading issue (not jumping to top after click)
2024-01-25 23:56 Patrick Schmalstig Note Added: 0008251
2024-01-29 12:07 Adam Edington Note Added: 0008270
2024-01-29 17:25 Patrick Schmalstig Note Added: 0008272
2024-02-09 03:31 Patrick Schmalstig Note Added: 0008296