View Issue Details

IDProjectCategoryView StatusLast Update
0005604Composrticketspublic2024-02-11 04:22
ReporterAdam EdingtonAssigned ToPatrick Schmalstig 
SeverityTrivial-bug 
Status closedResolutionno change required 
Product Version10.0.45 
Fixed in Version 
Summary0005604: Tickets language is hardcoded
DescriptionSearching for the text on the tickets page returns zero results in Admin Zone
Using the translate/rephrase option from the footer dropdown doesn't show the text
Changing the text in tickets.ini has no effect
Additional InformationYou are starting a new support ticket. Support tickets allow you to post private requests to our support staff.

Please try to make your ticket focus on a single issue – you can open as many as you like, and we'll be able to respond faster to individual tickets. Include any details that will be necessary for us to handle your request, such as system information, sample data, or any pertinent access details we would need.

We will respond as quickly as possible.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Relationships

related to 0005607 assignedPatrick Schmalstig Allow configuration options set to their defaults to dynamically change when the default changes 

Activities

Patrick Schmalstig

2024-02-10 20:56

administrator   ~0008321

Last edited: 2024-02-10 20:57

View 2 revisions

It is a config option.

Setup > Configuration > Message Options > Support Tickets.

Adam Edington

2024-02-10 21:02

administrator   ~0008322

Thanks for that, I couldn't find it and didn't expect it to be a config option (I thought I was quite familiar with all the options, clearly not).

Patrick Schmalstig

2024-02-10 21:06

administrator   ~0008323

No worries, haha. I'm surprised the search didn't come up with it because it is a language string to set the default value.

I'll have to look into that.

Adam Edington

2024-02-10 21:39

administrator   ~0008324

Last edited: 2024-02-10 21:43

View 2 revisions

Well changing the language string in tickets.ini didn't do anything for me, hence my suspicion it was hardcoded somewhere. I flushed my caches and everything :P

Patrick Schmalstig

2024-02-10 23:36

administrator   ~0008326

That's because Composr reads in the value of the language string as the default config option... and if you previously saved that page, then the raw value got saved with the option, meaning it was no longer associated with the language string.

Now that I think of it, this is probably not ideal. I might make an issue for v11... for every config option, if its value matches default, then blank the saved value out so it always reads in the default value instead (ideal for dynamically adjusting config options left to their default values when/if the default values change).

Chris Graham

2024-02-11 00:28

administrator   ~0008328

"Now that I think of it, this is probably not ideal. I might make an issue for
v11... for every config option, if its value matches default, then blank the
saved value out so it always reads in the default value instead (ideal for
dynamically adjusting config options left to their default values when/if the
default values change)."

It would need doing carefully. IIRC We have a field c_set, so you could set c_set=0 if it is just the same as the default. The actual value would still be copied in to the table as cached. You'd then need a new function that clears out cached values (values where c_set=0). You'd call that when lang files are edited.

Patrick Schmalstig

2024-02-11 04:22

administrator   ~0008330

See 0005607

Issue History

Date Modified Username Field Change
2024-02-10 20:54 Adam Edington New Issue
2024-02-10 20:55 Adam Edington Summary Tickets language appears to be hardcoded => Tickets language is hardcoded
2024-02-10 20:56 Patrick Schmalstig Note Added: 0008321
2024-02-10 20:57 Patrick Schmalstig Note Edited: 0008321 View Revisions
2024-02-10 21:02 Adam Edington Note Added: 0008322
2024-02-10 21:06 Patrick Schmalstig Note Added: 0008323
2024-02-10 21:39 Adam Edington Note Added: 0008324
2024-02-10 21:43 Adam Edington Note Edited: 0008324 View Revisions
2024-02-10 23:36 Patrick Schmalstig Note Added: 0008326
2024-02-11 00:28 Chris Graham Note Added: 0008328
2024-02-11 04:22 Patrick Schmalstig Assigned To => Patrick Schmalstig
2024-02-11 04:22 Patrick Schmalstig Status non-assigned => closed
2024-02-11 04:22 Patrick Schmalstig Resolution open => no change required
2024-02-11 04:22 Patrick Schmalstig Note Added: 0008330
2024-02-11 04:22 Patrick Schmalstig Relationship added related to 0005607