View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005688 | Composr | core | public | 2024-04-10 19:30 | 2024-04-28 22:22 |
| Reporter | Patrick Schmalstig | Assigned To | Patrick Schmalstig | ||
| Severity | Minor-bug | ||||
| Status | resolved | Resolution | fixed | ||
| Product Version | 10.0.47 | ||||
| Fixed in Version | 10.0.48.beta | ||||
| Summary | 0005688: load_html_page does not properly parse paths with query strings | ||||
| Description | If a path has a query string, then Composr fails to is_file check because the is_file check keeps the query string on it (resulting in the check returning false), thus Composr falls back to uploads/website_specific even if the file exists. Check if this bug exists also in v11. | ||||
| Additional Information | This is a bug that must be fixed for a client, thus high priority. | ||||
| Tags | Roadmap: v11 | ||||
| Time estimation (hours) | |||||
| Sponsorship open | |||||
| related to | 0005689 | resolved | Patrick Schmalstig | Add site_html_pages hooks |
|
|
Automated response: load_html_page does not properly parse paths with query strings If a path has a query string, then Composr fails to is_file check because the is_file check keeps the query string on it (resulting in the check returning false), thus Composr falls back to uploads/website_specific even if the file exists. This fix strips out query strings and fragments. It also adds site_html_pages hook functionality for additional processing of HTML pages. |
|
|
Fixed in git commit 29e22d14b1 (https://gitlab.com/composr-foundation/composr/commit/29e22d14b1 - link will become active once code pushed to GitLab) A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/). hotfix-5688, 2024-04-15 1am.tar (144,384 bytes) |
|
|
v11: https://gitlab.com/composr-foundation/composr/-/commit/b020ed9fabdbac62233bae89cfd1d08c37fdbae1 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-04-10 19:30 | Patrick Schmalstig | New Issue | |
| 2024-04-10 19:30 | Patrick Schmalstig | Status | non-assigned => assigned |
| 2024-04-10 19:30 | Patrick Schmalstig | Assigned To | => Patrick Schmalstig |
| 2024-04-10 23:50 | Patrick Schmalstig | Relationship added | related to 0005689 |
| 2024-04-15 01:16 | Patrick Schmalstig | Tag Attached: Roadmap: v11 | |
| 2024-04-15 01:18 | Patrick Schmalstig | Status | resolved => assigned |
| 2024-04-28 22:22 | Patrick Schmalstig | Status | assigned => resolved |
| 2024-04-28 22:22 | Patrick Schmalstig | Note Added: 0008709 |
