View Issue Details

IDProjectCategoryView StatusLast Update
0005725Composr alpha bug reports[Composr] galleriespublic2024-06-04 16:26
ReporterAdam EdingtonAssigned ToPatrick Schmalstig 
SeverityMinor-bug 
Status resolvedResolutionfixed 
Summary0005725: Cannot add gallery media to sub(sub)categories
DescriptionCreate a subcategory of a subcategory and even if images/videos are allowed, you cannot add or move items to this category,

EDIT: It seems the accepted types are not being saved, I ticked both videos and images but they are both reverting to unticked upon save.
TagsNo tags attached.
Sponsorship open

Activities

Adam Edington

2024-04-24 04:58

administrator  

Add a video.png (8,508 bytes)
Add a video.png (8,508 bytes)

Patrick Schmalstig

2024-05-01 01:17

administrator   ~0008731

I cannot reproduce. Can you provide an exact step-by-step replication situation?

Adam Edington

2024-05-01 01:48

administrator   ~0008736

Last edited: 2024-05-01 01:56

View 1 revisions

1) Created the Videos gallery which allows no images/videos to be uploaded under Galleries (root).
2) Created the A Dark Reborn "subgallery" which allows videos to be uploaded under Videos (videos).
3) Cannot upload videos to A Dark Reborn category. Cannot select the category in the tree.

Patrick Schmalstig

2024-05-05 17:53

administrator   ~0008749

This is so strange. It works fine on my end. Videos does not allow adding a video, but if I expand videos, I'm able to select A Dark Reborn. (This is on the add video screen).

When you go back to edit the A Dark Reborn gallery, does it still have accept videos ticked? Or is that not ticked when you try saving?

Patrick Schmalstig

2024-06-04 16:04

administrator   ~0008797

Alright I have a reproduction case now. It seems to happen when the Galleries Home / parent-most gallery has those options disabled. Unfortunately when disabled, the ticks won't even save for the parent gallery, effectively creating a lock-out.

admin

2024-06-04 16:25

administrator   ~0008798

Automated response: Cannot add gallery media to sub(sub)categories

The tickboxes for accepting images / videos were not being handled correctly. Value was being used to determine whether or not they were ticked, but it should have always been set to "1"; there was a separate parameter in form_input_various_ticks for determining if the ticks are ticked by default.

admin

2024-06-04 16:25

administrator   ~0008799

Fixed in Git commit bcaebfaacc (https://gitlab.com/composr-foundation/composr/commit/bcaebfaacc - link will become active once code pushed to GitLab)

admin

2024-06-04 16:25

administrator  

hotfix-5725, 2024-06-04 4pm.tar (118,272 bytes)

admin

2024-06-04 16:25

administrator   ~0008800

A hotfix (a TAR of files to upload) has been uploaded to this issue. Only apply this hotfix if you absolutely need it and cannot wait until the next release of Composr (releases are more reliable and strictly tested). As of Composr version 11, the recommended way to apply a hotfix is by following the same steps as an upgrade (https://baseurl/upgrader.php, use the hotfix on step 5). The upgrader will automatically skip files belonging to addons you do not have installed or that are newer on disk than in the hotfix. Otherwise, you can manually extract and replace these files (do not replace if your on-disk file is newer than the one in the hotfix). Always take backups of your site or at least files you are replacing before applying a hotfix. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Patrick Schmalstig

2024-06-04 16:26

administrator   ~0008801

Hah that's a first, a commit checksum with only letters in it

Issue History

Date Modified Username Field Change
2024-04-24 04:58 Adam Edington New Issue
2024-04-24 04:58 Adam Edington File Added: Add a video.png
2024-04-24 06:40 Adam Edington Description Updated View Revisions
2024-05-01 01:17 Patrick Schmalstig Note Added: 0008731
2024-05-01 01:48 Adam Edington Note Added: 0008736
2024-05-01 01:48 Adam Edington Note Edited: 0008736
2024-05-01 01:56 Adam Edington Note Edited: 0008736
2024-05-01 01:56 Adam Edington Note Edited: 0008736 View Revisions
2024-05-01 01:57 Adam Edington Note Revision Dropped: 8736: 0004292
2024-05-01 01:57 Adam Edington Note Revision Dropped: 8736: 0004293
2024-05-01 01:57 Adam Edington Note Revision Dropped: 8736: 0004294
2024-05-05 17:53 Patrick Schmalstig Note Added: 0008749
2024-06-04 16:04 Patrick Schmalstig Note Added: 0008797
2024-06-04 16:26 Patrick Schmalstig Note Added: 0008801