View Issue Details

IDProjectCategoryView StatusLast Update
0005764Composractionlogpublic2024-10-12 23:12
ReporterPatrick SchmalstigAssigned ToPatrick Schmalstig 
SeverityMinor-bug 
Status resolvedResolutionfixed 
Product Version11.beta3 
Fixed in Version 
Summary0005764: Incorrect page being passed to change_detection.php when using redirects
DescriptionWhen using a module redirect to another module, the wrong module is passed as the page to change_detection.php.

For example, if I have the feedback module redirect to support tickets, it triggers change detection (because support tickets) but the page parameter is "feedback", which triggers an error because no hook exists for that.
Additional InformationFor now, I added a commit which softly returns 0 / no changes if the hook does not exist.
TagsRoadmap: v11
Time estimation (hours)
Sponsorship open

Relationships

has duplicate 0005471 closedPatrick Schmalstig Composr alpha bug reports Error when running change detection script 

Activities

admin

2024-05-17 00:17

administrator   ~0008760

Automated message: This issue was created using the Report Issue Wizard on the Composr homesite.

admin

2024-10-12 23:12

administrator   ~0009471

Automated response: Incorrect page being passed to change_detection.php when using redirects

When using a module redirect to another module, the wrong module is passed as the page to change_detection.php.

This hotfix ensures internalise_own_screen considers page redirects when passing in page and zone parameters to change_detection.php .

Note this will NOT work for URL redirects; only page redirects.

admin

2024-10-12 23:12

administrator   ~0009472

Fixed in Git commit baafc7dfb8 (https://gitlab.com/composr-foundation/composr/commit/baafc7dfb8 - link will become active once code pushed to GitLab)

hotfix-5764, 2024-10-12 11pm.tar (24,576 bytes)

admin

2024-10-12 23:12

administrator   ~0009473

A hotfix (a TAR of files to upload) has been uploaded to this issue. Only apply this hotfix if you absolutely need it and cannot wait until the next release of Composr (releases are more reliable and strictly tested). As of Composr version 11, the recommended way to apply a hotfix is by following the same steps as an upgrade (https://baseurl/upgrader.php, use the hotfix on the step “Transfer across new/updated files”). The upgrader will automatically skip files belonging to addons you do not have installed or that are newer on disk than in the hotfix. Otherwise, you can manually extract and replace these files (do not replace if your on-disk file is newer than the one in the hotfix). Always take backups of your site or at least files you are replacing before applying a hotfix. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

Issue History

Date Modified Username Field Change
2024-09-13 03:15 Patrick Schmalstig Tag Attached: Roadmap: v11
2024-09-13 03:16 Patrick Schmalstig Relationship added has duplicate 0005559
2024-09-13 03:17 Patrick Schmalstig Relationship deleted has duplicate 0005559
2024-10-12 22:06 Patrick Schmalstig Relationship added has duplicate 0005471